svelte: Pass keywords to CrateHeader on all crate sub-pages#13370
Merged
Turbo87 merged 2 commits intorust-lang:mainfrom Apr 8, 2026
Merged
svelte: Pass keywords to CrateHeader on all crate sub-pages#13370Turbo87 merged 2 commits intorust-lang:mainfrom
keywords to CrateHeader on all crate sub-pages#13370Turbo87 merged 2 commits intorust-lang:mainfrom
Conversation
The Svelte app's crate sub-pages (versions, dependencies, reverse dependencies, security) don't pass keywords to the `CrateHeader` component, unlike the Ember app. These tests reproduce the issue.
The versions, dependencies, reverse dependencies, and security pages were rendering `CrateHeader` without passing the `keywords` prop, causing keywords to not appear in the header on those pages.
eth3lbert
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The versions, dependencies, reverse dependencies, and security pages were rendering
CrateHeaderwithout passing thekeywordsprop, causing keywords to not appear in the header on those pages.This PR adds regression tests for this behavior and fixes it by passing in the necessary props.
Related