move bibliography refs from database.py and difference_family.py to master index#41861
Open
aksharabhardwaj766-commits wants to merge 7 commits intosagemath:developfrom
Conversation
…y.py to master bibliography; refs sagemath#28445
Contributor
|
@vbraun workflows please |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR centralizes bibliography/citation definitions by removing locally defined REFERENCES blocks from combinatorics design modules and adding the corresponding citation entries to the master references index (src/doc/en/reference/references/index.rst) as part of #28445.
Changes:
- Removed locally defined reference blocks from
difference_family.pyanddatabase.pydocstrings. - Added the moved citation entries (and some related design-theory references) to the centralized
references/index.rst.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
src/sage/combinat/designs/difference_family.py |
Removes embedded citation definitions from module/function docstrings to rely on centralized references. |
src/sage/combinat/designs/database.py |
Removes embedded citation definitions; leaves one docstring with a now-bare URL that likely needs reformatting. |
src/doc/en/reference/references/index.rst |
Adds centralized citation entries for the moved references (but includes at least one formatting error that breaks citation resolution). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
Author
|
@cxzhong Any updates on the workflow approval? Thank you! |
Contributor
|
Contributor
|
please fix this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #28445.
Moves locally defined references from
src/sage/combinat/designs/database.pysrc/sage/combinat/designs/difference_family.pyinto the centralized bibliography at
src/doc/en/reference/references/index.rst.