Clarify intentional event.data check in handle_vacuum_start#399
Merged
Conversation
16 tasks
Contributor
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Comment |
Copilot
AI
changed the title
[WIP] Update code quality improvements and dataclass configurations
Clarify intentional event.data check in handle_vacuum_start
Dec 14, 2025
sca075
approved these changes
Dec 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
Addresses review feedback from #396 regarding the
if event.data:check inhandle_vacuum_start. The check is intentional -reset_trims()should only be called when event data is present to avoid unnecessary resets.No code changes required - this PR documents the design decision.
Type of change
Additional information
Checklist
ruff format)If user exposed functionality or configuration variables are added/changed:
If the code communicates uses new third-party tools or libraries:
manifest.json.devbranch, notmain.💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.