refactor: remove @segment/action-emitters dependency#3844
Open
nick-Ag wants to merge 1 commit into
Open
Conversation
…ntEmitterSlug type The action-emitters package is being deprecated. This inlines the only type we depend on (EventEmitterSlug) into a local file to eliminate the external dependency. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the deprecated @segment/action-emitters dependency from packages/core by inlining the only referenced type (EventEmitterSlug) into destination-kit.
Changes:
- Replaced the
EventEmitterSlugimport from@segment/action-emitterswith a local type import. - Added
packages/core/src/destination-kit/event-emitter-types.tscontaining the hardcodedEventEmitterSlugunion type. - Removed
@segment/action-emittersfrompackages/core/package.jsondependencies.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/core/src/destination-kit/index.ts | Switches EventEmitterSlug to a local type source used by exported preset types. |
| packages/core/src/destination-kit/event-emitter-types.ts | Introduces the local EventEmitterSlug type definition. |
| packages/core/package.json | Drops the deprecated @segment/action-emitters dependency. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@segment/action-emitterspackage dependency from@segment/actions-coreEventEmitterSlugtype locally inpackages/core/src/destination-kit/event-emitter-types.tsTest plan
yarn typecheckin core)yarn installpassesyarn buildpasses🤖 Generated with Claude Code