Fix base-lint staticcheck SA5011 in sbom-builder tests#13523
Closed
Copilot wants to merge 3 commits into
Closed
Conversation
Copilot
AI
changed the title
[WIP] Fix failing GitHub Actions job base-lint
Fix base-lint staticcheck SA5011 in sbom-builder tests
Jun 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
base-lintGitHub Actions job failed inlint-go-toolsdue to staticcheck (SA5011) reporting possible nil dereferences intools/sbom-builder/main_test.go. This update makes the nil-guard control flow explicit so the test code passes static analysis.Root cause in test assertions
findPackage(...)results were nil-checked witht.Fatalf(...), but staticcheck still flagged subsequent field access as potentially unsafe.Targeted test-only control-flow fix
returnimmediately after the twot.Fatalf(...)nil checks:TestAddOSPackage_AddsSiblingWithRefsTestAddGoModulePackageIllustrative diff pattern