feat: add UnattendedInstall config and controller#13591
Open
shanduur wants to merge 1 commit into
Open
Conversation
shanduur
force-pushed
the
feat/unattended-install-config
branch
from
84d542d to
48fc83b
Compare
Member
|
I think legacyBIOSSupport is something really old and we should drop it, I don't think any code uses that |
smira
reviewed
Jun 17, 2026
| // description: | | ||
| // Indicates if legacy GRUB bootloader should use kernel cmdline from the UKI instead of building it on the host. | ||
| // This changes the way cmdline is managed with GRUB bootloader to be more consistent with UKI/systemd-boot. | ||
| InstallGrubUseUKICmdline *bool `yaml:"grubUseUKICmdline,omitempty"` |
Member
There was a problem hiding this comment.
I think we should lock it to true in the new config, we don't need to keep backwards compatibility in the new machine config document.
smira
reviewed
Jun 17, 2026
| // description: | | ||
| // Indicates if MBR partition should be marked as bootable (active). | ||
| // Should be enabled only for the systems with legacy BIOS that doesn't support GPT partitioning scheme. | ||
| InstallLegacyBIOSSupport *bool `yaml:"legacyBIOSSupport,omitempty"` |
Member
There was a problem hiding this comment.
same as Noel, I think we can skip it for now, not sure if anyone still needs this, this is only for legacy/BIOS boot flow on some old hardware.... if someone needs that still (I don't think we even test it today), it could be in the API (?)
shanduur
force-pushed
the
feat/unattended-install-config
branch
11 times, most recently
from
8020d0d to
0dc50b1
Compare
shanduur
added
integration/misc
Replace the deprecated v1alpha1 `.machine.install` section with a new `UnattendedInstall` multi-document config kind, driven by a dedicated `UnattendedInstallController` (single-flight, no reboot) that exposes an `UnattendedInstallStatus` resource. - Deprecate `.machine.install`; no longer required in validation. - Gate behind version contract (>= 1.14); `talosctl gen config` and `cluster create` emit `UnattendedInstall` by default for new contracts, translating `--install-disk` into a CEL disk selector. - Source `legacyBIOSSupport`/`grubUseUKICmdline` from the new document in the installer, falling back to `.machine.install`. - Skip the legacy install sequence (and its reboot) when the document is present; install is reconciled out-of-band. Signed-off-by: Mateusz Urbanek <mateusz.urbanek@siderolabs.com>
shanduur
force-pushed
the
feat/unattended-install-config
branch
from
0dc50b1 to
491ce75
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the deprecated v1alpha1
.machine.installsection with a newUnattendedInstallmulti-document config kind, driven by a dedicatedUnattendedInstallController(single-flight, no reboot) that exposes anUnattendedInstallStatusresource..machine.install; no longer required in validation.talosctl gen configandcluster createemitUnattendedInstallby default for new contracts,translating
--install-diskinto a CEL disk selector.legacyBIOSSupport/grubUseUKICmdlinefrom the new document inthe installer, falling back to
.machine.install.present; install is reconciled out-of-band.
Signed-off-by: Mateusz Urbanek mateusz.urbanek@siderolabs.com