Add robust_log and robust_exp to link functions#74
Merged
simon-hirsch merged 13 commits intomainfrom Apr 28, 2025
Merged
Conversation
BerriJ
approved these changes
Apr 25, 2025
Collaborator
BerriJ
left a comment
BerriJ
left a comment
There was a problem hiding this comment.
Nothing suspicious found.
BerriJ
approved these changes
Apr 25, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request adds robust_log and robust_exp based implementations as well as inverse softplus link functions, expanding the available link function options. The changes include modifications to test definitions, new implementations in softpluslinks.py and robust_math.py, updates to the package’s exports in init.py, and logging improvements in online_gamlss.py.
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/test_link_functions.py | Updated test cases to include the new inverse softplus link functions. |
| src/rolch/link/sqrtlinks.py | No changes beyond reordering of link function groups. |
| src/rolch/link/softpluslinks.py | Added InverseSoftPlusLink and InverseSoftPlusShift*Link classes using robust math. |
| src/rolch/link/robust_math.py | Introduced robust_log, robust_exp, and related helper functions for stability. |
| src/rolch/link/loglinks.py | No functional changes; maintained consistency with robust math usage. |
| src/rolch/link/identitylinks.py | No functional changes. |
| src/rolch/link/init.py | Updated module exports; note duplicate entry for SqrtShiftTwoLink. |
| src/rolch/estimators/online_gamlss.py | Added logging message for conditional start values during parameter fitting. |
| src/rolch/init.py | Updated exports to include the new inverse softplus link functions. |
| docs/links.md | Documented the newly added link function options. |
Comments suppressed due to low confidence (1)
src/rolch/link/init.py:19
- Duplicate export of 'SqrtShiftTwoLink' detected. Please remove the redundant entry to keep the module exports clean and consistent.
"SqrtShiftTwoLink",
BerriJ
approved these changes
Apr 25, 2025
Collaborator
BerriJ
left a comment
BerriJ
left a comment
There was a problem hiding this comment.
I think we can merge this now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.