Add authorized re-encryption of past transfers by eduv09 · Pull Request #66 · skalenetwork/confidential-token

eduv09 · 2026-04-06T17:23:11Z

Fixes #63

Copilot

Pull request overview

This PR implements “authorized re-encryption” for historical transfers, enabling selective disclosure of encrypted transfer data to permitted viewers (Issue #63), plus an automatic recipient-readable encrypted value event when the recipient has a registered public key.

Changes:

Added on-chain historic transfer disclosure primitives: EncryptedTransfer emission, viewer authorization (time range / transferId), and requestDecryptHistoricTransfer → ReEncryptedTransfer.
Added automatic per-transfer TransferValueEncryptedForRecipient emission (ECIES to recipient key when registered).
Expanded test coverage and updated README + generated interface/contract docs for the new disclosure flows.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
`contracts/ConfidentialToken.sol`	Core implementation for emitting encrypted transfer metadata and handling authorized historic re-encryption requests.
`contracts/interfaces/IConfidentialToken.sol`	Adds structs/events/errors and new public API for historic view authorization + decrypt requests.
`test/ConfidentialToken.ts`	Extensive tests for authorization, edge cases, fee charging, replay, and recipient auto-encryption.
`README.md`	Documents the historic transfer decryption feature and the recipient auto-encrypted value event.
`docs/interfaces/IConfidentialToken.md`	Generated interface docs updated to include new structs/events/functions.
`docs/ConfidentialToken.md`	Generated contract docs updated for new internal/external functions and updated signatures.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

codecov · 2026-04-06T17:40:56Z

Codecov Report

❌ Patch coverage is 98.58156% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 97.38%. Comparing base (5167aaf) to head (d0f1a17).

Files with missing lines	Patch %	Lines
contracts/ConfidentialToken.sol	97.91%	2 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop      #66      +/-   ##
===========================================
+ Coverage    96.66%   97.38%   +0.71%     
===========================================
  Files            6        7       +1     
  Lines          270      382     +112     
  Branches        64       94      +30     
===========================================
+ Hits           261      372     +111     
- Misses           9       10       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

…ey changes

Copilot

Pull request overview

Copilot reviewed 22 out of 23 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 22 out of 23 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 22 out of 23 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 22 out of 23 changed files in this pull request and generated 4 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 22 out of 23 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

…terface

Copilot

Pull request overview

Copilot reviewed 22 out of 23 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 22 out of 23 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 22 out of 23 changed files in this pull request and generated 4 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-04-23T15:51:31Z

+        (address from, address to) = _historicViewAuth.decodeIfAuthorized(
+            sender,
+            decryptedArguments[0]
+        );


_handleHistoricViewRequest indexes decryptedArguments[0] without first validating that the callback provided at least one decrypted argument. If decryptedArguments is empty (or shorter than expected), this will revert with a panic (out-of-bounds) rather than a controlled custom error. Add an explicit length check (e.g., require decryptedArguments.length == 1) and revert with a project error like DecryptionBadFormat/WrongPlaintextFormat for predictable behavior.

Copilot · 2026-04-23T15:51:31Z

+        address sender = address(bytes20(plaintextArguments[1]));
+        require(_knownPublicKey(sender), PublicKeyIsNotRegistered(sender));
+
+        (address from, address to) = _historicViewAuth.decodeIfAuthorized(
+            sender,
+            decryptedArguments[0]
+        );
+        emit ReEncryptedTransfer(
+            sender,
+            from,
+            to,
+            BITE.encryptECIES(
+                encryptECIESAddress,
+                decryptedArguments[0],
+                publicKeys[sender]


In _handleHistoricViewRequest, the local variable sender is actually the historic-view viewer address extracted from plaintextArguments[1]. Renaming it to viewer/historicViewer would make the authorization and ReEncryptedTransfer emission logic much easier to follow and reduce confusion with msg.sender / transfer sender.

Suggested change

address sender = address(bytes20(plaintextArguments[1]));

require(_knownPublicKey(sender), PublicKeyIsNotRegistered(sender));

(address from, address to) = _historicViewAuth.decodeIfAuthorized(

sender,

decryptedArguments[0]

);

emit ReEncryptedTransfer(

sender,

from,

to,

BITE.encryptECIES(

encryptECIESAddress,

decryptedArguments[0],

publicKeys[sender]

address historicViewer = address(bytes20(plaintextArguments[1]));

require(_knownPublicKey(historicViewer), PublicKeyIsNotRegistered(historicViewer));

(address from, address to) = _historicViewAuth.decodeIfAuthorized(

historicViewer,

decryptedArguments[0]

);

emit ReEncryptedTransfer(

historicViewer,

from,

to,

BITE.encryptECIES(

encryptECIESAddress,

decryptedArguments[0],

publicKeys[historicViewer]

Copilot · 2026-04-23T15:51:31Z

+const deploy = async () => {
+    console.log(chalk.yellow("Deploying AccessManager..."));
+    const accessManagerFactory = await ethers.getContractFactory("AccessManager");
+    accessManager = await accessManagerFactory.deploy(deployer);


accessManagerFactory.deploy(deployer) passes a SignerWithAddress object where the OpenZeppelin AccessManager constructor expects an address (initial admin). This is likely to throw at runtime with an “invalid address” error on ethers v6. Pass deployer.address (or await deployer.getAddress()) instead.

Suggested change

accessManager = await accessManagerFactory.deploy(deployer);

accessManager = await accessManagerFactory.deploy(deployer.address);

Copilot · 2026-04-23T15:51:32Z

+    /// @notice Emitted when a holder revokes a viewer's access to transfers within a time range.
+    /// @param holder Address of the holder revoking access.
+    /// @param viewer Address of the viewer losing access.
+    event HistoricViewTimeRangeRevoked(address indexed holder,address indexed viewer);


Minor formatting: HistoricViewTimeRangeRevoked is declared as event HistoricViewTimeRangeRevoked(address indexed holder,address indexed viewer); (missing a space after the comma). Align spacing with the rest of the interface for readability.

Suggested change

event HistoricViewTimeRangeRevoked(address indexed holder,address indexed viewer);

event HistoricViewTimeRangeRevoked(address indexed holder, address indexed viewer);

eduv09 self-assigned this Apr 6, 2026

eduv09 requested a review from Copilot April 6, 2026 17:29

Copilot started reviewing on behalf of eduv09 April 6, 2026 17:29 View session

Copilot AI reviewed Apr 6, 2026

View reviewed changes

eduv09 marked this pull request as ready for review April 8, 2026 12:41

eduv09 requested a review from DimaStebaev as a code owner April 8, 2026 12:41

DimaStebaev reviewed Apr 10, 2026

View reviewed changes

Comment thread contracts/ConfidentialToken.sol Outdated

Comment thread contracts/ConfidentialToken.sol Outdated

Comment thread contracts/interfaces/IConfidentialToken.sol Outdated

eduv09 added 5 commits April 13, 2026 11:08

Add authorized re-encryption of past transfers

1f40012

fix documentation, bug in _handleDecryption, and omit event in view k…

0d7b5cb

…ey changes

Add script to test decription and functionality on live network

e11c9c0

fix spelling

3b1bd3b

refactor Historic decryption and fix solidity pragma

3c26898

Copilot AI review requested due to automatic review settings April 13, 2026 15:14

eduv09 force-pushed the encrypted-events branch from 39201de to 3c26898 Compare April 13, 2026 15:14

Copilot started reviewing on behalf of eduv09 April 13, 2026 15:15 View session

fix pragma solidity to be compatible with bite-solidity

e64dae2

Copilot AI reviewed Apr 13, 2026

View reviewed changes

Comment thread contracts/ConfidentialToken.sol Outdated

Comment thread contracts/ConfidentialToken.sol Outdated

Comment thread contracts/interfaces/IConfidentialToken.sol

fix spelling and natSpec comments

3ea309f

Copilot AI review requested due to automatic review settings April 13, 2026 15:43

Copilot started reviewing on behalf of eduv09 April 13, 2026 15:43 View session

Copilot AI reviewed Apr 13, 2026

View reviewed changes

Comment thread scripts/deployAndTestMintableCnfToken.ts

Comment thread scripts/deployAndTestMintableCnfToken.ts

Comment thread contracts/HistoricView.sol Outdated

re-implement allways return true if not revert logic

da20709

eduv09 force-pushed the encrypted-events branch from b66b604 to da20709 Compare April 13, 2026 15:49

Update contracts/HistoricView.sol Licence

80419b3

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings April 13, 2026 15:51

Copilot started reviewing on behalf of eduv09 April 13, 2026 15:51 View session

Copilot AI reviewed Apr 13, 2026

View reviewed changes

Comment thread contracts/ConfidentialToken.sol Outdated

Comment thread contracts/HistoricView.sol Outdated

Comment thread scripts/deployAndTestMintableCnfToken.ts

eduv09 requested a review from DimaStebaev April 14, 2026 13:00

DimaStebaev reviewed Apr 14, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings April 14, 2026 16:26

Copilot started reviewing on behalf of eduv09 April 14, 2026 16:26 View session

eduv09 force-pushed the encrypted-events branch from 5ffa472 to 1df43a8 Compare April 14, 2026 16:29

eduv09 requested review from Copilot and removed request for Copilot April 14, 2026 16:29

eduv09 force-pushed the encrypted-events branch from 1df43a8 to 8243fe1 Compare April 14, 2026 16:32

Copilot AI reviewed Apr 14, 2026

View reviewed changes

Comment thread contracts/interfaces/IConfidentialToken.sol Outdated

Comment thread contracts/interfaces/IConfidentialToken.sol Outdated

Comment thread docs/interfaces/IConfidentialToken.md Outdated

Comment thread README.md Outdated

Copilot started reviewing on behalf of eduv09 April 14, 2026 16:32 View session

eduv09 force-pushed the encrypted-events branch from 8243fe1 to 571adc1 Compare April 14, 2026 16:35

add validation of plaintext arguments onDecrypt

2050616

Copilot AI review requested due to automatic review settings April 14, 2026 16:40

eduv09 force-pushed the encrypted-events branch from 571adc1 to 2050616 Compare April 14, 2026 16:40

Copilot started reviewing on behalf of eduv09 April 14, 2026 16:40 View session

Copilot AI reviewed Apr 14, 2026

View reviewed changes

Comment thread test/ConfidentialToken.ts

Comment thread contracts/ConfidentialToken.sol Outdated

Comment thread contracts/ConfidentialToken.sol Outdated

DimaStebaev reviewed Apr 16, 2026

View reviewed changes

Comment thread contracts/HistoricView.sol Outdated

Comment thread contracts/ConfidentialToken.sol Outdated

Comment thread contracts/HistoricView.sol Outdated

DimaStebaev reviewed Apr 16, 2026

View reviewed changes

Comment thread contracts/ConfidentialToken.sol Outdated

eduv09 added 2 commits April 16, 2026 16:33

Style fixes, adjust allowed time ranges, and ad revoke function to in…

ad43afa

…terface

fix lint

c10cf98

Copilot AI review requested due to automatic review settings April 16, 2026 15:35

Copilot started reviewing on behalf of eduv09 April 16, 2026 15:36 View session

Copilot AI reviewed Apr 16, 2026

View reviewed changes

Comment thread contracts/ConfidentialToken.sol Outdated

Comment thread contracts/HistoricView.sol Outdated

Comment thread contracts/interfaces/IConfidentialToken.sol

eduv09 added 2 commits April 17, 2026 08:59

fix logic in hadPermissions and remove unused lines

5892111

refactor given feedback from confidential pay

ca619d1

Copilot AI review requested due to automatic review settings April 23, 2026 15:33

Copilot started reviewing on behalf of eduv09 April 23, 2026 15:33 View session

Copilot AI reviewed Apr 23, 2026

View reviewed changes

Comment thread README.md Outdated

Comment thread scripts/deployAndTestMintableCnfToken.ts

Update README.md

d0f1a17

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings April 23, 2026 15:44

Copilot started reviewing on behalf of eduv09 April 23, 2026 15:45 View session

Copilot AI reviewed Apr 23, 2026

View reviewed changes

	accessManager = await accessManagerFactory.deploy(deployer);
	accessManager = await accessManagerFactory.deploy(deployer.address);

	event HistoricViewTimeRangeRevoked(address indexed holder,address indexed viewer);
	event HistoricViewTimeRangeRevoked(address indexed holder, address indexed viewer);

Conversation

eduv09 commented Apr 6, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codecov Bot commented Apr 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

codecov Bot commented Apr 6, 2026 •

edited

Loading