fix: propagate real error when machineBash fails in createWorktree#1115
Open
AlseinX wants to merge 1 commit intoslopus:mainfrom
Open
fix: propagate real error when machineBash fails in createWorktree#1115AlseinX wants to merge 1 commit intoslopus:mainfrom
AlseinX wants to merge 1 commit intoslopus:mainfrom
Conversation
createWorktree unconditionally reported "Not a Git repository" for any machineBash failure, hiding RPC errors and network issues. Now checks exitCode === -1 (RPC/communication failure) and forwards the real error. Fixes slopus#1110 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
m-bers
added a commit
to m-bers/happy
that referenced
this pull request
Apr 18, 2026
…chineBash fails in createWorktree
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
createWorktreenow differentiates RPC/communication failures (exitCode === -1) from genuine "not a git repo" errors, propagating the real error message instead of always reporting "Not a Git repository"Test plan
Fixes #1110
🤖 Generated with Claude Code