fix: markdown table row alignment#984
Closed
chaehyun2 wants to merge 1 commit intoslopus:mainfrom
Closed
Conversation
Switch table rendering from column-first to row-first (HTML <tr> style): - Cells in the same row share height naturally via flex row - Header row separated with bottom border - Equal column widths via flex: 1 - minHeight: 40 prevents collapsed empty cells - minWidth: 100% ensures table fills container - Horizontal scroll indicator always visible Generated with [Claude Code](https://claude.ai/code) via [Happy](https://happy.engineering) Co-Authored-By: Claude <noreply@anthropic.com> Co-Authored-By: Happy <yesreply@happy.engineering>
cb30e22 to
39640e8
Compare
Contributor
Author
|
Closing — upstream rewrote the table rendering with dynamic column widths, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<tr>)flex: 1instead of content-dependent sizingminHeight: 40prevents collapsed empty cellsminWidth: 100%on table content ensures small tables fill container widthChanges
Single file:
packages/happy-app/sources/components/markdown/MarkdownView.tsx(+44/-35)Before (column-first): each column was a vertical container — cells in the same row could have different heights, and wide content clipped.
After (row-first): each row is a horizontal flex container — consistent row heights, proper text wrapping, clean borders.
Test plan
🤖 Generated with Claude Code
via Happy