fix: add absenceStrs to OP.GG and TikTok Online Viewer (false positives)#2497
fix: add absenceStrs to OP.GG and TikTok Online Viewer (false positives)#2497lui62233 wants to merge 1 commit intosoxoj:mainfrom
Conversation
Fix false positives reported in issues soxoj#2494, soxoj#2495, soxoj#2496. Add absence strings to prevent non-existent usernames from being falsely reported as CLAIMED.
|
Thanks a lot, the updates were released without a proper check. I'm fixing them in #2499. |
|
Could you please rebase the branch and patch only TikTok Online Viewer, without changes to other lines? |
|
Thanks — I saw the latest review note and I am taking another pass on it. I will follow up here once the branch is updated or if I need clarification. |
|
Thanks — I saw this. I will review the failing checks / test expectation and push an update if needed. |
|
I pushed a follow-up on this branch and tightened the behavior around the issue you flagged. Taking another pass now that the patch is up. Fixed in the latest branch update (a5e4f8a). |
|
Thanks a lot for the fix! However, I see that data.json file was rewrote completely (Lines changed: 35340 additions & 35330 deletions). It's difficult to track the changes, so could you please, to apply your changes only for one website check? |
Summary
Fix false-positive detection for:
Fix
Added
absenceStrsentries to the site definitions inmaigret/resources/data.json:["No player data", "No summoner", "No results found"]["No results found", "User not found", "not found"]The detection logic in
maigret/checking.pychecks for absence keywords to distinguish between actual profiles and non-existent usernames. Without these strings, any page matching presence keywords is incorrectly marked as CLAIMED.