Skip to content

fix: add absenceStrs to OP.GG and TikTok Online Viewer (false positives)#2497

Open
lui62233 wants to merge 1 commit intosoxoj:mainfrom
lui62233:fix-false-positives-opgg-tiktok
Open

fix: add absenceStrs to OP.GG and TikTok Online Viewer (false positives)#2497
lui62233 wants to merge 1 commit intosoxoj:mainfrom
lui62233:fix-false-positives-opgg-tiktok

Conversation

@lui62233
Copy link
Copy Markdown

@lui62233 lui62233 commented Apr 9, 2026

Summary

Fix false-positive detection for:

Fix

Added absenceStrs entries to the site definitions in maigret/resources/data.json:

  • OP.GG Turkey/Vietnam: ["No player data", "No summoner", "No results found"]
  • TikTok Online Viewer: ["No results found", "User not found", "not found"]

The detection logic in maigret/checking.py checks for absence keywords to distinguish between actual profiles and non-existent usernames. Without these strings, any page matching presence keywords is incorrectly marked as CLAIMED.

Fix false positives reported in issues soxoj#2494, soxoj#2495, soxoj#2496.
Add absence strings to prevent non-existent usernames from being falsely reported as CLAIMED.
@soxoj
Copy link
Copy Markdown
Owner

soxoj commented Apr 9, 2026

Thanks a lot, the updates were released without a proper check. I'm fixing them in #2499.

@soxoj
Copy link
Copy Markdown
Owner

soxoj commented Apr 9, 2026

Could you please rebase the branch and patch only TikTok Online Viewer, without changes to other lines?
All OP.GG checks are fixed atm.

@lui62233
Copy link
Copy Markdown
Author

lui62233 commented Apr 9, 2026

Thanks — I saw the latest review note and I am taking another pass on it. I will follow up here once the branch is updated or if I need clarification.

@lui62233
Copy link
Copy Markdown
Author

lui62233 commented Apr 9, 2026

Thanks — I saw this. I will review the failing checks / test expectation and push an update if needed.

@lui62233
Copy link
Copy Markdown
Author

I pushed a follow-up on this branch and tightened the behavior around the issue you flagged. Taking another pass now that the patch is up. Fixed in the latest branch update (a5e4f8a).

@soxoj
Copy link
Copy Markdown
Owner

soxoj commented Apr 10, 2026

Thanks a lot for the fix! However, I see that data.json file was rewrote completely (Lines changed: 35340 additions & 35330 deletions). It's difficult to track the changes, so could you please, to apply your changes only for one website check?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants