spectral extraction: updates for Spectrum1D support in specreduce#1847
Closed
kecnry wants to merge 2 commits intospacetelescope:mainfrom
Closed
spectral extraction: updates for Spectrum1D support in specreduce#1847kecnry wants to merge 2 commits intospacetelescope:mainfrom
kecnry wants to merge 2 commits intospacetelescope:mainfrom
Conversation
* revert this commit once glue handles non-linear wavelength scaling
ab3810b to
6150fba
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request implements the changes in jdaviz needed to make use of the improvements in astropy/specreduce#144 to add support for
specutils.Spectrum1Dsupport. This will also enable us to support keeping the spectral-axis/WCS throughout the spectral extraction process (although that is temporarily disabled here until the proper plotting support is implemented upstream).Once specreduce 144 is merged and released, this PR should pin that new release and should then be tested (although it does currently seem to work as expected with the current state of the PR branch).
Change log entry
CHANGES.rst? If you want to avoid merge conflicts,list the proposed change log here for review and add to
CHANGES.rstbefore merge. If no, maintainershould add a
no-changelog-entry-neededlabel.Checklist for package maintainer(s)
This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.
triviallabel.