Conversation
|
Right now it feels inelegant to have to provide the (keyword argument) file formats all before the (positional argument) filenames, e.g.: It might make more sense to change filenames to a keyword argument as well so you could provide each filename/format pair in a sensible order. Thoughts? |
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (17.07%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #4115 +/- ##
==========================================
- Coverage 84.55% 84.53% -0.02%
==========================================
Files 204 204
Lines 29833 29979 +146
==========================================
+ Hits 25225 25344 +119
- Misses 4608 4635 +27 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
b5cd0da to
7e3e19c
Compare
Make our Solara script more like MAST's, try using ipyvuetify Sheet
docs/quickstart.rst
Outdated
| for example, using either the image loader or the catalog loader. The current list of supported file formats is: | ||
|
|
||
| * Image | ||
| * Catalog | ||
| * 1D Spectrum | ||
| * 2D Spectrum | ||
| * 3D Spectrum | ||
| * Ramp | ||
| * Ramp Integration | ||
| * Subset | ||
| * Trace | ||
| * Line List | ||
| * Footprint |
There was a problem hiding this comment.
is there some auto-generated place we can point to for this (perhaps index on the formats page) so we don't risk this getting out-of-date?
There was a problem hiding this comment.
I can try to do that. There's definitely an error message that pops up in the UI if a compatible format isn't found listing them all, I'll find where that comes from.
There was a problem hiding this comment.
Hm, the list in the formats index page is hard coded as well, not auto generated. I'll link there so at least we only have to update one place.
This enables loading multiple files with format specified through CLI. The user needs to be able to specify the file format for the loader to load files in deconfigged from the CLI. This enables that with a
file_formatargument, which should be specified for each file, e.g.:This PR also fixes the faulty rendering of extra
file-browserandfile-dropelements above the app when specifying a--layoutargument from the command line.