Optimize response caching by reducing unnecessary hasBeenCached met…#515
Closed
atom1285 wants to merge 2 commits intospatie:mainfrom
Closed
Optimize response caching by reducing unnecessary hasBeenCached met…#515atom1285 wants to merge 2 commits intospatie:mainfrom
hasBeenCached met…#515atom1285 wants to merge 2 commits intospatie:mainfrom
Conversation
…hod calls and adding an integration test.
…return types accordingly.
Member
|
I'm going to leave it as it is for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…hod calls and adding an integration test.
I noticed in my application that sentry complained about N+1 query issues in the CacheResponse middleware.
It turned out this is because when laravel cache checks for a key in the cache (the has method), it actually calls the get method and compares if the result is null.
By removing the hasBeenCached we get rid of the duplicated query.
This pull request is more of a question thought, the tests that fail make that think that this may have been on purpose or was embraced in the codebase. If my change is welcome just let me know and I will also update the failing tests so everything is in order. Have a great day.