Skip to content

PR: Replace deprecated distutils and pipes modules#352

Merged
ccordoba12 merged 4 commits into
spyder-ide:masterfrom
juliangilbey:deprecations
Nov 13, 2025
Merged

PR: Replace deprecated distutils and pipes modules#352
ccordoba12 merged 4 commits into
spyder-ide:masterfrom
juliangilbey:deprecations

Conversation

@juliangilbey
Copy link
Copy Markdown
Contributor

This addresses the points I made in #349 (comment) replacing pipes with shlex and distutils with setuptools and looseversion.

This patch can be applied after #349, but the package will not build without the updates there.

@dalthviz dalthviz added this to the v1.3.0 milestone Nov 11, 2025
@dalthviz dalthviz changed the title Replace deprecated distutils and pipes modules PR: Replace deprecated distutils and pipes modules Nov 11, 2025
@dalthviz
Copy link
Copy Markdown
Member

Thanks @juliangilbey for your work here! I'm updating the PR with master via the GitHub interface to have CI checks but from a quick glance, maybe the addition of a new dependecy for LooseVersion could be discussed (I'm fine with a new dependency but maybe that check where is used could be removed 🤔 what do you think about that @ccordoba12 ?) and something that maybe could be worthy to add here too is CI with Python 3.13. Other than that this looks good to me 👍

Let us know if you want to further work on this or if it is okay for us to take over and push this forward!

@juliangilbey
Copy link
Copy Markdown
Contributor Author

Thanks @juliangilbey for your work here! I'm updating the PR with master via the GitHub interface to have CI checks but from a quick glance, maybe the addition of a new dependecy for LooseVersion could be discussed (I'm fine with a new dependency but maybe that check where is used could be removed 🤔 what do you think about that @ccordoba12 ?) and something that maybe could be worthy to add here too is CI with Python 3.13. Other than that this looks good to me 👍

Let us know if you want to further work on this or if it is okay for us to take over and push this forward!

Hi Daniel,

Thanks for picking this up! I've been totally overwhelmed with work in recent months and sadly have no time to work on this at the moment. I'm really happy for you to take over :)

Best wishes,

Julian

@ccordoba12
Copy link
Copy Markdown
Member

I'm fine with a new dependency but maybe that check where is used could be removed 🤔 what do you think about that @ccordoba12 ?

Yeah, it can. It's checking for a version greater than Mac 10.15, which is really old now. So, please remove it.

@dalthviz dalthviz changed the title PR: Replace deprecated distutils and pipes modules PR: Replace deprecated distutils and pipes modules Nov 13, 2025
@dalthviz dalthviz requested a review from ccordoba12 November 13, 2025 21:41
Copy link
Copy Markdown
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @juliangilbey and @dalthviz!

@ccordoba12 ccordoba12 merged commit eb29193 into spyder-ide:master Nov 13, 2025
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants