Skip to content

No:2743 - 𝐒 Improve GameStudio's About window - Added a new markdown plugin window to show "MIT License" and "See all list" links in the About page#2921

Merged
Kryptos-FR merged 5 commits intostride3d:xplat-editorfrom
jithishkumarg:jithishg-xplat-ed-Issue-2743
Oct 18, 2025
Merged

No:2743 - 𝐒 Improve GameStudio's About window - Added a new markdown plugin window to show "MIT License" and "See all list" links in the About page#2921
Kryptos-FR merged 5 commits intostride3d:xplat-editorfrom
jithishkumarg:jithishg-xplat-ed-Issue-2743

Conversation

@jithishkumarg
Copy link
Copy Markdown

@jithishkumarg jithishkumarg commented Oct 5, 2025

… show the markdown files

PR Details

Related Issue

#2743

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My change requires a change to the documentation.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have built and run the editor to try this change out.

@VaclavElias
Copy link
Copy Markdown
Contributor

Nice. Can we have some screenshots?

Comment thread sources/editor/Stride.GameStudio.Avalonia/Stride.GameStudio.Avalonia.csproj Outdated
Comment thread sources/Directory.Packages.props Outdated
Comment thread sources/editor/Stride.GameStudio.Avalonia/Services/MarkdownFileViewerService.cs Outdated
Comment thread sources/editor/Stride.GameStudio.Avalonia/Services/MarkdownFileViewerService.cs Outdated
Comment thread sources/editor/Stride.GameStudio.Avalonia/Services/MarkdownFileViewerService.cs Outdated
Comment thread sources/editor/Stride.GameStudio.Avalonia/Views/MarkdownViewerWindow.axaml.cs Outdated
@jithishkumarg
Copy link
Copy Markdown
Author

Nice. Can we have some screenshots?

Sure, I will attach them below.

@jithishkumarg
Copy link
Copy Markdown
Author

@Kryptos-FR Apologies for the delay, I will work on these and update.

@jithishkumarg
Copy link
Copy Markdown
Author

@VaclavElias
Third Party Licenses popup
Screenshot 2025-10-16 103650
MIT License
Screenshot 2025-10-16 103634

1) .axaml files and their .cs counterpart are detected automatically. There is no need to add them to the project file.
2) Packages are grouped depending on their runtime or design dependency.
3) nit: use file scope namespace
4) nit: this shouldn't be necessary thanks to implicit usings.
5) I think this helper method should be made async.
6) This should be generated automatically by the analyzers provided by Avalonia libraries.
@jithishkumarg
Copy link
Copy Markdown
Author

@Kryptos-FR Addressed the issues and committed the changes. Could you please review and let me know if any additional changes are needed

@Kryptos-FR
Copy link
Copy Markdown
Member

@jithishkumarg Thanks. I made some cleanup but otherwise it looks ok.

Please agree to the policy bot. Otherwise we can't merge your contribution.

@Kryptos-FR Kryptos-FR marked this pull request as ready for review October 18, 2025 14:57
@jithishkumarg
Copy link
Copy Markdown
Author

@dotnet-policy-service agree

@jithishkumarg
Copy link
Copy Markdown
Author

Thank you @Kryptos-FR and I agreed to the policy bot. Also, would you mind assigning the issue to me. Thank you

@Kryptos-FR Kryptos-FR linked an issue Oct 18, 2025 that may be closed by this pull request
@Kryptos-FR Kryptos-FR merged commit 9803615 into stride3d:xplat-editor Oct 18, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Development

Successfully merging this pull request may close these issues.

😊🔵𝐒 Improve GameStudio's About window

3 participants