Conversation
…be editable by the customer), but currently limited to a single connector. ConfigurationWriterTest.kt still needs to have the mocks adjusted and currently has most of its tests disabled.
…be editable by the customer), but currently limited to a single connector. ConfigurationWriterTest.kt still needs to have the mocks adjusted and currently has most of its tests disabled.
…operty origin is a file inside a jar
| logger.debug { "set '${changedConfigItem.propertyPath}' to '${newValue}' as type '${newValue::class}'" } | ||
| } | ||
|
|
||
| is Float -> { |
There was a problem hiding this comment.
do we have any type defined as float? Or is that so that it would be covered? (if so, then what about Long?)
There was a problem hiding this comment.
Yes, it is there "just in case". And yes, I forgot to add Long. Added now.
| <include resource="org/springframework/boot/logging/logback/console-appender.xml" /> | ||
|
|
||
| <logger name="com.swisscom.health.des.cdr.client" level="DEBUG" /> | ||
| <!-- <logger name="org" level="INFO" />--> |
| name = DomainObjects.ConfigurationItem.CDR_API_HOST, | ||
| modifier = modifier.padding(8.dp).fillMaxWidth(), | ||
| initiallyExpanded = false, | ||
| options = { listOf("cdr.health.swisscom.ch", "stg.cdr.health.swisscom.ch") }, |
There was a problem hiding this comment.
I'm not sure that we want to have this in place, as we risk that someone selects the wrong one accidentally and then our support will have issues finding out why they get an error regarding "wrong credentials"
There was a problem hiding this comment.
Will replace it with a regular text field and use the prod URL as the hint text.
|
|
||
| Divider(modifier = modifier) | ||
|
|
||
| // TODO: replace with a dropdown to select the environment and set CDR host and tenant ID accordingly |
There was a problem hiding this comment.
The tenant-id is probably not something that we want to put in a public repository
There was a problem hiding this comment.
Will replace it with a regular text field and squash the history of the branch.
|
Bypassed review requirement as Daniel is on vacation... |
rsteppac
deleted the
feature/413066-common-service-configuration-validation
branch
2 participants
…be editable by the customer), but currently limited to a single connector. ConfigurationWriterTest.kt still needs to have the mocks adjusted and currently has most of its tests disabled.