Sy 3833 strongly type schematics

[emilbon99]

Pull Request

Go to the Preview tab and select the appropriate template for your pull request:

• Issue
• RC

Greptile Summary

This PR strongly types the schematic data model by replacing the opaque Data msgpack.EncodedJSON blob in v54 with explicit Nodes, Edges, Props, Legend, and Authority fields — both server-side (Go) and client-side (TypeScript v6 state). Node/edge/props data is now owned by the server; the console Redux slice retains only UI state (selection, control status, toolbar, viewport). Action-based mutation (SetNodePosition, AddNode, SetEdge, SetProps, etc.) now drives server-side state transitions with real-time fan-out via the sy_schematic_set signal channel.

• P1: extractLegend in migrate.go writes to a nil Colors map and calls color.MustFromHex (panics on any malformed hex string) — any schematic with legend colors that triggers migration will crash the server on upgrade.

Confidence Score: 4/5

Not safe to merge until the nil map + MustFromHex panics in extractLegend are fixed — these will crash the server during first upgrade migration of any schematic with legend colors.

The architectural restructuring is well-designed and the generated code is correct throughout. A single P1 bug in migrate.go will cause a runtime panic in the migration path for existing schematics with legend colors. All other files are clean.

core/pkg/service/schematic/migrate.go — extractLegend writes to nil Colors map and calls color.MustFromHex on unvalidated user data.

Vulnerabilities

No security concerns identified beyond the migration-time panic from color.MustFromHex on unvalidated input (addressed as P1 inline). Auth/authz, injection vectors, and secrets handling are unchanged from prior versions.

Important Files Changed

Filename	Overview
core/pkg/service/schematic/migrate.go	Migration helper with nil map panic and MustFromHex panic risk in extractLegend; extractViewport is dead code
core/pkg/service/schematic/types.gen.go	Generated: strongly-typed Schematic struct replacing opaque Data blob; Legend, Node, Edge, Handle, Segment all defined
core/pkg/service/schematic/actions.gen.go	Generated: Action discriminated union and ReduceAll for schematic mutations; unknown types no-op (forward compat)
core/pkg/service/schematic/actions.go	Clean action handlers; AddNode/SetProps correctly lazy-init Props map; delete on nil map in RemoveNode is safe
core/pkg/service/schematic/writer.go	Dispatch applies ReduceAll atomically via ChangeErr; nil-guard on actionObserver prevents panics in test mode
core/pkg/service/schematic/writer_test.go	Good Ginkgo coverage: Create, Rename, Dispatch (position/sequence/edge), nonexistent-key error, Copy with ontology verification
client/ts/src/schematic/client.ts	Clean TS client; dispatch forwards sessionKey for self-dedup; all request/response Zod-validated
client/ts/src/schematic/actions.gen.ts	Generated TS discriminated union actions; reduceAll wraps in immer produce; null handling differs intentionally between AddNode and SetProps
client/ts/src/schematic/types.gen.ts	Generated TS zod schemas; nodes/edges use nullishToEmpty, authority defaults to 1, newZ correctly makes key/snapshot optional
console/src/schematic/remote.ts	Returns ZERO_STATE from remote (server data intentionally discarded), enforcing v6 server/UI state separation
console/src/schematic/types/v6.ts	v6: nodes/edges/props/authority/snapshot moved server-side; client state is UI-only (selection, viewport, toolbar, editable)
console/src/schematic/types/migrations.spec.ts	Comprehensive migration tests v0-v5 to v6; explicitly asserts server-side fields absent from migrated state
pluto/src/schematic/queries.ts	Flux API; ACTION_LISTENER enables real-time collaboration via sy_schematic_set; augmentWithEdgeSegments keeps edge routing consistent on node moves
schemas/schematic.oracle	Complete Oracle schema driving TS/Go/protobuf codegen; actions declared inline on Schematic, AddNode props optional vs SetProps required drives null-handling split

Sequence Diagram

sequenceDiagram
    participant C as Console
    participant SC as Schematic Client (TS)
    participant SV as Schematic Service (Go)
    participant DB as gorp DB
    participant SIG as Signals Channel
    participant C2 as Other Clients

    C->>SC: dispatch(key, actions, sessionKey)
    Note over SC: augmentWithEdgeSegments adds<br/>SetProps for moved edges
    SC->>SV: POST /schematic/dispatch
    SV->>DB: ChangeErr(ReduceAll(state, actions))
    DB-->>SV: updated Schematic
    SV->>SIG: Publish ScopedAction {key, sessionKey, actions}
    SIG-->>C: sy_schematic_set channel event
    Note over C: ACTION_LISTENER: skip if sessionKey == client.key
    SIG-->>C2: sy_schematic_set channel event
    C2->>C2: reduceAll(current, changed.actions)

Loading

_{Reviews (1): Last reviewed commit: "updated python client channel tests" | Re-trigger Greptile}

Greptile also left 2 inline comments on this PR.