feat: Support aws_lb_listener_rule.transform, regex_values, and update docs#422
Merged
bryantbiggs merged 2 commits intoterraform-aws-modules:masterfrom Nov 1, 2025
Merged
Conversation
bryantbiggs
reviewed
Oct 31, 2025
Member
bryantbiggs
left a comment
bryantbiggs
left a comment
There was a problem hiding this comment.
looks great - one minor comment on removing the pluralization
| - Security group rules now use a default naming scheme of `<security-group-name>-<map-key>` unless a more specific rule name is provided. | ||
| - `rule.actions.type` has been replaced with `rule.actions.<type>`. See before/after below for more details. | ||
| - `query_string` supports a list of key:value pairs; type definition updated to support this (i.e. was `map(string)` and is now `list(map(string))`) | ||
| - `aws_lb_listener.ssl_policy` now defaults to `ELBSecurityPolicy-TLS13-1-3-2021-06` |
main.tf
Outdated
| priority = each.value.priority | ||
|
|
||
| dynamic "transform" { | ||
| for_each = each.value.transforms != null ? each.value.transforms : {} |
Member
There was a problem hiding this comment.
I know we've been inconsistent elsewhere but lets match the API with the singular form
Suggested change
| for_each = each.value.transforms != null ? each.value.transforms : {} | |
| for_each = each.value.transform != null ? each.value.transform : {} |
variables.tf
Outdated
| listener_key = optional(string) | ||
| priority = optional(number) | ||
| tags = optional(map(string), {}) | ||
| transforms = optional(map(object({ |
Member
There was a problem hiding this comment.
Suggested change
| transforms = optional(map(object({ | |
| transform = optional(map(object({ |
bryantbiggs
approved these changes
Nov 1, 2025
antonbabenko
pushed a commit
that referenced
this pull request
Nov 1, 2025
## [10.1.0](v10.0.2...v10.1.0) (2025-11-01) ### Features * Support `aws_lb_listener_rule.transform`, `regex_values`, and update docs ([#422](#422)) ([2f90229](2f90229))
Member
|
This PR is included in version 10.1.0 🎉 |
This was referenced Nov 3, 2025
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Support
aws_lb_listener_rule.transformblock.Support
regex_valuesincondition.host_header,condition.http_header, andcondition.path_pattern.Update v10 upgrade doc to specify new
ssl_policydefault.Motivation and Context
Breaking Changes
No.
How Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projectspre-commit run -aon my pull request