fix: Remove limits_per_label_set from aws_prometheus_workspace_configuration conditional creation statement#31
Merged
bryantbiggs merged 1 commit intoterraform-aws-modules:masterfrom Dec 15, 2025
Conversation
bryantbiggs
changed the title
limits_per_label_set from aws_prometheus_workspace_configuration conditional creation statement
bryantbiggs
approved these changes
Dec 15, 2025
antonbabenko
pushed a commit
that referenced
this pull request
Dec 15, 2025
## [4.2.1](v4.2.0...v4.2.1) (2025-12-15) ### Bug Fixes * Remove `limits_per_label_set` from `aws_prometheus_workspace_configuration` conditional creation statement ([#31](#31)) ([855166c](855166c))
Member
|
This PR is included in version 4.2.1 🎉 |
3 tasks
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Remove
limits_per_label_setfrom if statement ofaws_prometheus_workspace_configurationresourceMotivation and Context
limits_per_label_setis anOPTIONALin the doc https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/prometheus_workspace_configurationHaving it in the if statement, it creates a behaviour where user defines
retention_period_in_daysand nothing happensBreaking Changes
Not applicable
How Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projectspre-commit run -aon my pull request