Merged
Conversation
🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Previously, Terratunnel was double-encoding query parameters, converting commas to %2C. This fix preserves the raw query string from the server and uses it directly in the client, avoiding re-encoding by httpx. - Server now includes raw_query_string in request data - Client uses raw query string when available (no re-encoding) - Maintains backward compatibility for older servers Fixes issue where URLs like ?page=n,malcolm-demo were becoming ?page=n%2Cmalcolm-demo 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
schonfinkel
approved these changes
Sep 22, 2025
- Support list query parameters using repeated keys (e.g., page=n&page=malcolm-demo) - Preserve exact query string encoding (e.g., %3D for equals, %2C for comma) - Fix logging to show encoded query strings, not decoded values - Both features work together seamlessly - Maintains full backward compatibility Server changes: - Use list(request.query_params.multi_items()) for list param support - Capture raw_query_string for encoding preservation Client changes: - Use raw_query_string when available to preserve encoding - Handle both dict and list of tuples formats for query_params - Update logging to show encoded values
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.