Merged
Conversation
jessicamcinchak
approved these changes
Mar 10, 2025
Member
jessicamcinchak
left a comment
jessicamcinchak
left a comment
There was a problem hiding this comment.
Looks great! One minor comment/suggestion 👍
| projecting: Integer; | ||
| }; | ||
| otherAdvertisements: boolean; | ||
| started: boolean; |
Member
There was a problem hiding this comment.
nit: do we need started: boolean; if the ProposalDates above include the actual start date? Perhaps redundant and we can favor only dates?
Collaborator
Author
There was a problem hiding this comment.
Good catch! I was wondering the utility of this as well. I'll update.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Edited the Applicant, Proposal, ApplicationData, Property types. Added extra filetype to accommodate AdvertConsent application.