ase/Makefile.mk: fix libsndfile support for flac, ogg and opus files#78
ase/Makefile.mk: fix libsndfile support for flac, ogg and opus files#78swesterfeld wants to merge 1 commit intotrunkfrom
Conversation
Signed-off-by: Stefan Westerfeld <stefan@space.twc.de>
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request aims to fix libsndfile support for FLAC, Ogg, and Opus files by updating header paths and using pkg-config for linking. The changes are a good step towards a more robust build process. I've found one issue with the list of libraries passed to pkg-config where a required library is missing and others are redundant. My suggestion should resolve this.
| $(LIBSNDFILE_OBJECTS), \ | ||
| ase/Makefile.mk | $>/lib/, \ | ||
| -lmpg123 -lmp3lame, \ | ||
| $(shell $(PKG_CONFIG) --libs \ |
There was a problem hiding this comment.
Take a look at config-checks.mk, that's where we do all pkg checks in one place and cache them.
Once the packages are determined present there its just a matter of adding *_CFLAGS or *_LIBS elsewhere in the Makefiles.
| $Q echo " __has_include(<vorbisfile.h>) && \\" >> $@.tmp | ||
| $Q echo " __has_include(<vorbisenc.h>) && \\" >> $@.tmp | ||
| $Q echo " __has_include(<opus.h>) )" >> $@.tmp | ||
| $Q echo " __has_include(<FLAC/all.h>) && \\" >> $@.tmp |
There was a problem hiding this comment.
<flac.h> looks indeed odd, i don't have that in externals/ or /usr/include/.
2 participants
I found that LiquidSFZ in Anklang does not load .flac or .ogg files. This PR fixes libsndfile support for these formats for me.