-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Feature/cog 4469 graph aware embeddings integrate joint postgres graph db and #2587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Vasilije1990
merged 57 commits into
dev
from
feature/cog-4469-graph-aware-embeddings-integrate-joint-postgres-graph-db-and
Apr 11, 2026
Merged
Changes from 62 commits
Commits
Show all changes
57 commits
Select commit
Hold shift + click to select a range
b754a4d
[wip] Add postgres backend for graphs.
DanielNScott 3282ffa
[wip] Raise where postgres graphDB incompatible with graphDB consumers
DanielNScott 7ee2e6e
[pass] Add tests and fixes for postgres graph adapter.
DanielNScott 6952dd8
[pass] Apply formatting guidelines via ruff.
DanielNScott e5e1232
[pass] Update documentation
DanielNScott 61c0b05
[wip] Add postgres hybrid adapter combining graph and vector backends.
DanielNScott 34d144a
[wip] Extend pghybrid incompatibility checks to match postgres ones.
DanielNScott 47794eb
[pass] Add unit tests for postgres hybrid adapter.
DanielNScott 36c4520
[wip] Add postgres backend for graphs.
DanielNScott f0396d5
[wip] Raise where postgres graphDB incompatible with graphDB consumers
DanielNScott 4347a95
[pass] Add tests and fixes for postgres graph adapter.
DanielNScott b6a533a
[pass] Apply formatting guidelines via ruff.
DanielNScott a69929f
[pass] Update documentation
DanielNScott dea9d50
[pass] Add USE_UNIFIED_PROVIDER flag and pghybrid e2e test.
DanielNScott 0781aaf
[wip] Batch SQL operations in postgres graph adapter.
DanielNScott fe1c3b0
[pass] Unify schema definition into SQLAlchemy Core table objects.
DanielNScott 1a846b6
[pass] Address PR #2506 review comments on postgres graph adapter.
DanielNScott 36837f7
[pass] Address new PR review nitpicks.
DanielNScott 7d637ad
Merge commit '7cfb55ff' into feature/cog-4469-graph-aware-embeddings-…
DanielNScott b3203b3
Merge branch 'feature/cog-4463-graph-aware-embeddings-implement-minim…
DanielNScott e5c0e5e
[pass] Move postgres-dependent tests to new e2e/postgres directory.
DanielNScott ea5efcd
[pass] Defensive tweaks throughout pghybrid system.
DanielNScott ffc246c
[pass] More tweaks in pghybrid sub-system.
DanielNScott c42cf17
[pass] Document get_triplets_batch as optional method on GraphDBInter…
DanielNScott 03625fa
[pass] Fix pghybrid test CI integration.
DanielNScott 2a7e388
[pass] Use hybrid adds in add_data_points when possible.
DanielNScott 3317006
[pass] Add equivalence test, fix edge payload in hybrid adapter.
DanielNScott 4c216aa
[pass] Fix CI env vars, interface contract, vector upsert, and triple…
DanielNScott f19e7d2
Merge branch 'dev' into feature/cog-4463-graph-aware-embeddings-imple…
lxobr 70fe9ff
[pass] Fix hybrid adapter deadlocks, pgvector overhead, recreation.
DanielNScott 986cfd7
[pass] Decouple postgres graph adapter from relational layer.
DanielNScott 5335918
Merge branch 'feature/cog-4463-graph-aware-embeddings-implement-minim…
DanielNScott 5f6ae51
[pass] Implement get_neighborhood and fix interface compliance after …
DanielNScott 6f33e6f
Merge branch 'dev' into feature/cog-4463-graph-aware-embeddings-imple…
lxobr 3a2b785
[pass] Reformat via pre-commit hooks
DanielNScott eafce01
Merge branch 'dev' into feature/cog-4463-graph-aware-embeddings-imple…
lxobr 34a4ffe
[pass] Move postgres-dependent tests to e2e/postgres directory.
DanielNScott da6a001
Merge remote-tracking branch 'upstream/feature/cog-4463-graph-aware-e…
DanielNScott f784a7a
[pass] Implement AND logic for node_name_filter_operator in get_nodes…
DanielNScott 6b2af3f
[pass] Address CodeRabbit review items on PR #2584.
DanielNScott 1941db7
[pass] Tweaks: batch dedup, node tuple shape, and triplet ordering.
DanielNScott ac55c48
Merge branch 'feature/cog-4463-graph-aware-embeddings-implement-minim…
DanielNScott 3f659fb
[pass] Fix PostgresAdapter constructor calls after 4463 merge.
DanielNScott 14fb30b
Merge remote-tracking branch 'upstream/feature/cog-4469-graph-aware-e…
DanielNScott 71d9b47
Merge remote-tracking branch 'upstream/dev' into feature/cog-4469-gra…
DanielNScott 935ff16
[pass] Fix add_data_points test mock taking hybrid write path.
DanielNScott 5e23c76
[pass] Fix add_data_points test mock and add hybrid write path test.
DanielNScott 5065c8e
[pass] Fix lockfile, unified provider gate, edge guard, and test isol…
DanielNScott 606e57f
[pass] Move pghybrid env check out of lru_cache in graph and vector f…
DanielNScott e1ed4d4
[pass] Fix LIMIT applied to join fan-out in search_graph_with_distances.
DanielNScott ad8c140
[pass] Fix hybrid adapter interface compliance and test fixture.
DanielNScott 57e9665
[pass] Fix embeddable field lookup in add_nodes_with_vectors.
DanielNScott 5145cba
[pass] Fix ruff formatting in PGVectorAdapter.
DanielNScott 5f63a26
Merge branch 'dev' of https://github.com/topoteretes/cognee into feat…
DanielNScott 1efdc0a
[pass] Clear PGVector metadata cache on prune, fix hybrid init docstr…
DanielNScott d66f152
Merge branch 'dev' of https://github.com/topoteretes/cognee into feat…
DanielNScott 575da72
[pass] Add postgres extra to CI setup for graph adapter tests.
DanielNScott File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Empty file.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🌐 Web query:
In GitHub pull_request payloads, what does author_association = "CONTRIBUTOR" mean, and is it considered equivalent to OWNER/MEMBER/COLLABORATOR for trust decisions?💡 Result:
Web search failed: Server error: no LLM provider could handle the message
🏁 Script executed:
Repository: topoteretes/cognee
Length of output: 79
🌐 Web query:
GitHub pull request author_association field values meaning OWNER MEMBER COLLABORATOR CONTRIBUTOR documentation💡 Result:
In GitHub’s
author_associationfield (an enum namedCommentAuthorAssociation), these values mean:Source: GitHub GraphQL enum docs for
CommentAuthorAssociation. [1]References
[1] https://docs.github.com/en/enterprise-cloud@latest/graphql/reference/enums#commentauthorassociation
🏁 Script executed:
Repository: topoteretes/cognee
Length of output: 2117
🏁 Script executed:
# Read CONTRIBUTING.md to verify DCO policy requirements cat -n CONTRIBUTING.mdRepository: topoteretes/cognee
Length of output: 7165
Remove
CONTRIBUTORfrom trusted roles to enforce DCO policyLine 26 includes
CONTRIBUTORintrustedRoles, allowing external contributors who have previously committed to bypass DCO enforcement (lines 29–35). However,CONTRIBUTORin GitHub'sauthor_associationfield means "has previously committed to the repository," not organizational membership or trusted collaborator status. This contradicts the comment on line 25 ("OWNER, MEMBER, and COLLABORATOR are trusted roles") and violates the DCO requirement stated in CONTRIBUTING.md section 5, which mandates DCO affirmation for all contributions.Suggested fix
📝 Committable suggestion
🤖 Prompt for AI Agents
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not our contribution, outside scope.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DanielNScott, understood — I'll drop this for the current PR. Would you like me to open a follow-up GitHub issue to track removingCONTRIBUTORfrom thetrustedRolesarray in.github/workflows/approve_dco.yaml, so it doesn't get lost?🧠 Learnings used