Open
Conversation
Contributor
There was a problem hiding this comment.
Copilot reviewed 20 out of 21 changed files in this pull request and generated 1 comment.
Files not reviewed (1)
- backend/package.json: Language not supported
Comments suppressed due to low confidence (2)
backend/types/userTypes.ts:44
- The 'activitiesCompleted' field in LearnerDTO uses string arrays, but the corresponding field in the user model uses ObjectId arrays. Consider aligning these types or clearly documenting the conversion to ensure consistency.
+ activitiesCompleted: Map<string, Map<string, string[]>>;
backend/services/implementations/courseModuleService.ts:66
- The identifier 'Schema' is used in fetchPage without a corresponding import. Import 'Schema' from 'mongoose' (or reference mongoose.Schema) to avoid runtime errors.
private static async fetchPage(page: Schema.Types.ObjectId): Promise<CoursePage> {
137c89c to
3db7130
Compare
3a3541c to
3024ba0
Compare
465b4ac to
a88a5eb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notion ticket link
Learner Course Progress Tracking
Implementation description
activitiesCompletedfield for learners that specifies the object IDs of course pages that a learner has viewed (or completed if it's an activity)nextPagefield to track the next page that the learner should be directed to when they return to the sitenextPagefield.Steps to test
PUT /users/learner/markActivityCompleted,GET /users/learner/progress, andPUT /users/learner/viewedPageWhat should reviewers focus on?
Checklist