fix: lint permission issue by emirot · Pull Request #9740 · velero-io/velero

emirot · 2026-04-22T04:39:06Z

Thank you for contributing to Velero!

Please add a summary of your change

When doing make lint locally I get this issue #9702

Does your change fix a particular issue?

After

➜  velero git:(fix/lint_issue) ✗ make lint
Using Cached Image: velero/build-image:eb0a1814c
Dir: /.cache/golangci-lint
Size: 4.6MiB
Running golangci-lint run

Please indicate you've done the following:

Accepted the DCO. Commits without the DCO will delay acceptance.
Created a changelog file (make new-changelog) or comment /kind changelog-not-required on this PR.
Updated the corresponding documentation in site/content/docs/main.

emirot · 2026-04-22T04:47:50Z

@blackpiglet @lubronzhan

codecov · 2026-04-22T04:48:50Z

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

blackpiglet · 2026-04-22T07:00:59Z

Please create the .go/goimports directory here.

@mkdir -p .go/src/$(PKG) .go/pkg .go/bin .go/std/$(GOOS)/$(GOARCH) .go/go-build .go/golangci-lint .go/goimports

blackpiglet

Please check my comments for details.
The current change doesn't look right.

Signed-off-by: emirot <emirot.nolan@gmail.com>

This commit update the actions "Auto Assign Author", "Auto Label PRs", and "Auto Request Review" Signed-off-by: Daniel Jiang <daniel.jiang@broadcom.com> Signed-off-by: emirot <emirot.nolan@gmail.com>

…rds (velero-io#9684) * Fix wildcard expansion when includes is empty and excludes has wildcards When a Backup CR is applied via kubectl with empty includedNamespaces and a wildcard in excludedNamespaces, ShouldExpandWildcards triggers expansion. The empty includes expands to nil, but wildcardExpanded is set to true, causing ShouldInclude to return false for all namespaces. Populate expanded includes with all active namespaces when the original includes was empty (meaning "include all") so that the wildcardExpanded check does not falsely reject everything. Signed-off-by: Joseph <jvaikath@redhat.com> * Changelog Signed-off-by: Joseph <jvaikath@redhat.com> * Normalize empty includes to * instead of active namespaces list This ensures consistent behavior between CLI and kubectl-apply paths for Namespace CR inclusion when excludes contain wildcards. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Joseph <jvaikath@redhat.com> * Move empty includes normalization to backup controller Instead of normalizing empty IncludedNamespaces to ["*"] in the collections layer's ExpandIncludesExcludes, do it earlier in prepareBackupRequest. This ensures the spec is correct before any downstream processing. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Joseph <jvaikath@redhat.com> * Update TestProcessBackupCompletions for wildcard normalization Add IncludedNamespaces: []string{"*"} to all expected BackupSpec structs, reflecting the new prepareBackupRequest normalization. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Joseph <jvaikath@redhat.com> * Add checks around empty includenamespaces Signed-off-by: Joseph <jvaikath@redhat.com> * gofmt Signed-off-by: Joseph <jvaikath@redhat.com> --------- Signed-off-by: Joseph <jvaikath@redhat.com> Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: emirot <emirot.nolan@gmail.com>

…#9613) Signed-off-by: Peter Woodman <peter@shortbus.org> Signed-off-by: emirot <emirot.nolan@gmail.com>

klog v2 defaults -logtostderr to true, which silently ignores the -stderrthreshold flag — all log levels are unconditionally sent to stderr. This makes it impossible for log-aggregation systems to filter by severity. Bump klog to v2.140.0 and opt into the fixed behavior by setting legacy_stderr_threshold_behavior=false and stderrthreshold=INFO (which preserves current output while letting users override via CLI flags). Ref: kubernetes/klog#212, kubernetes/klog#432 Signed-off-by: Pierluigi Lenoci <pierluigilenoci@gmail.com> Signed-off-by: emirot <emirot.nolan@gmail.com>

Add missing changelog entry for PR 9654 (fixes Changelog Check). Add explanation to //nolint:errcheck directives (fixes nolintlint). Signed-off-by: Pierluigi Lenoci <pierluigilenoci@gmail.com> Signed-off-by: emirot <emirot.nolan@gmail.com>

Signed-off-by: Xun Jiang <xun.jiang@broadcom.com> Signed-off-by: emirot <emirot.nolan@gmail.com>

Bumps [go.opentelemetry.io/otel](https://github.com/open-telemetry/opentelemetry-go) from 1.40.0 to 1.41.0. - [Release notes](https://github.com/open-telemetry/opentelemetry-go/releases) - [Changelog](https://github.com/open-telemetry/opentelemetry-go/blob/main/CHANGELOG.md) - [Commits](open-telemetry/opentelemetry-go@v1.40.0...v1.41.0) --- updated-dependencies: - dependency-name: go.opentelemetry.io/otel dependency-version: 1.41.0 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: emirot <emirot.nolan@gmail.com>

Per action.yml of the action, the token is required. https://github.com/necojackarc/auto-request-review/blob/e89da1a8cd7c8c16d9de9c6e763290b6b0e3d424/action.yml#L8 Signed-off-by: Daniel Jiang <daniel.jiang@broadcom.com> Signed-off-by: emirot <emirot.nolan@gmail.com>

Signed-off-by: Lyndon-Li <lyonghui@vmware.com> Signed-off-by: emirot <emirot.nolan@gmail.com>

Bumps [go.opentelemetry.io/otel/sdk](https://github.com/open-telemetry/opentelemetry-go) from 1.40.0 to 1.43.0. - [Release notes](https://github.com/open-telemetry/opentelemetry-go/releases) - [Changelog](https://github.com/open-telemetry/opentelemetry-go/blob/main/CHANGELOG.md) - [Commits](open-telemetry/opentelemetry-go@v1.40.0...v1.43.0) --- updated-dependencies: - dependency-name: go.opentelemetry.io/otel/sdk dependency-version: 1.43.0 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: emirot <emirot.nolan@gmail.com>

Signed-off-by: emirot <emirot.nolan@gmail.com>

emirot · 2026-04-28T03:11:05Z

@blackpiglet please take a second look

blackpiglet · 2026-04-28T03:23:17Z

 build-dirs:
 	@mkdir -p _output/bin/$(GOOS)/$(GOARCH)
 	@mkdir -p .go/src/$(PKG) .go/pkg .go/bin .go/std/$(GOOS)/$(GOARCH) .go/go-build .go/golangci-lint
+	@mkdir -p .go/src/$(PKG) .go/pkg .go/bin .go/std/$(GOOS)/$(GOARCH) .go/go-build .go/golangci-lint .go/goimports


@mkdir -p .go/src/$(PKG) .go/pkg .go/bin .go/std/$(GOOS)/$(GOARCH) .go/go-build .go/golangci-lint @mkdir -p .go/src/$(PKG) .go/pkg .go/bin .go/std/$(GOOS)/$(GOARCH) .go/go-build .go/golangci-lint .go/goimports

No need to have two lines for the same usage. Please combine them together.

@mkdir -p .go/src/$(PKG) .go/pkg .go/bin .go/std/$(GOOS)/$(GOARCH) .go/go-build .go/golangci-lint .go/goimports

https://github.com/velero-io/velero/pull/9740/changes#r3151366281 Signed-off-by: Tiger Kaovilai <passawit.kaovilai@gmail.com>

github-actions Bot assigned emirot Apr 22, 2026

github-actions Bot added the has-changelog label Apr 22, 2026

emirot mentioned this pull request Apr 22, 2026

Make lint on fresh install gives me permission denied #9702

Open

kaovilai previously approved these changes Apr 22, 2026

View reviewed changes

blackpiglet reviewed Apr 22, 2026

View reviewed changes

Comment thread Makefile Outdated

blackpiglet requested changes Apr 22, 2026

View reviewed changes

emirot dismissed kaovilai’s stale review via d7775df April 27, 2026 17:02

emirot and others added 14 commits April 27, 2026 10:03

fix: lint permission issue

7d96632

Signed-off-by: emirot <emirot.nolan@gmail.com>

fix: lint permission issue

709380c

Signed-off-by: emirot <emirot.nolan@gmail.com>

Set permissions to the actions

be598bd

This commit update the actions "Auto Assign Author", "Auto Label PRs", and "Auto Request Review" Signed-off-by: Daniel Jiang <daniel.jiang@broadcom.com> Signed-off-by: emirot <emirot.nolan@gmail.com>

update hashicorp/go-hclog and go-plugin to current version (velero-io…

c0f4eda

…#9613) Signed-off-by: Peter Woodman <peter@shortbus.org> Signed-off-by: emirot <emirot.nolan@gmail.com>

Remove Restic code path from PodVolumeRestore.

5e1da21

Signed-off-by: Xun Jiang <xun.jiang@broadcom.com> Signed-off-by: emirot <emirot.nolan@gmail.com>

fix go-releaser upload error

1c46b6c

Signed-off-by: Lyndon-Li <lyonghui@vmware.com> Signed-off-by: emirot <emirot.nolan@gmail.com>

add concurrency limit to go-releaser

b669e05

Signed-off-by: Lyndon-Li <lyonghui@vmware.com> Signed-off-by: emirot <emirot.nolan@gmail.com>

fix(lint): fix lint local

a6d9a0a

Signed-off-by: emirot <emirot.nolan@gmail.com>

emirot force-pushed the fix/lint_issue branch from d7775df to a6d9a0a Compare April 27, 2026 17:03

github-actions Bot added Dependencies Pull requests that update a dependency file has-unit-tests labels Apr 27, 2026

Merge branch 'main' into fix/lint_issue

6a873e9

kaovilai previously approved these changes Apr 27, 2026

View reviewed changes

blackpiglet reviewed Apr 28, 2026

View reviewed changes

kaovilai reviewed Apr 28, 2026

View reviewed changes

Comment thread Makefile Outdated

Apply suggestion from @blackpiglet

79e18c0

https://github.com/velero-io/velero/pull/9740/changes#r3151366281 Signed-off-by: Tiger Kaovilai <passawit.kaovilai@gmail.com>

kaovilai dismissed their stale review via 79e18c0 April 28, 2026 04:12

kaovilai requested a review from blackpiglet April 28, 2026 04:13

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: lint permission issue#9740

fix: lint permission issue#9740
emirot wants to merge 16 commits intovelero-io:mainfrom
emirot:fix/lint_issue

emirot commented Apr 22, 2026 •

edited

Loading

Uh oh!

emirot commented Apr 22, 2026

Uh oh!

codecov Bot commented Apr 22, 2026

Uh oh!

blackpiglet Apr 22, 2026 •

edited

Loading

Uh oh!

Uh oh!

blackpiglet left a comment

Uh oh!

emirot commented Apr 28, 2026 •

edited

Loading

Uh oh!

blackpiglet Apr 28, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Conversation

emirot commented Apr 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Please add a summary of your change

Does your change fix a particular issue?

Please indicate you've done the following:

Uh oh!

emirot commented Apr 22, 2026

Uh oh!

codecov Bot commented Apr 22, 2026

Codecov Report

Uh oh!

blackpiglet Apr 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

blackpiglet left a comment

Choose a reason for hiding this comment

Uh oh!

emirot commented Apr 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

blackpiglet Apr 28, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

emirot commented Apr 22, 2026 •

edited

Loading

blackpiglet Apr 22, 2026 •

edited

Loading

emirot commented Apr 28, 2026 •

edited

Loading