Skip to content

feat: RelationalBone add getDefaultValue#1172

Draft
ArneGudermann wants to merge 5 commits intoviur-framework:developfrom
ArneGudermann:feat/RelationalBone_getDefaultValue
Draft

feat: RelationalBone add getDefaultValue#1172
ArneGudermann wants to merge 5 commits intoviur-framework:developfrom
ArneGudermann:feat/RelationalBone_getDefaultValue

Conversation

@ArneGudermann
Copy link
Copy Markdown
Contributor

Fix for #1152

@ArneGudermann ArneGudermann added the Priority: Medium This issue may be useful, and needs some attention. label May 24, 2024
@ArneGudermann ArneGudermann added this to the ViUR-core v3.7 milestone May 24, 2024
@ArneGudermann ArneGudermann marked this pull request as ready for review May 24, 2024 10:02
elif isinstance(value, list):
return self._hashValueForUniquePropertyIndex([x["dest"]["key"] for x in value])

def getDefaultValue(self, skeletonInstance):
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about multilang?

@sveneberth sveneberth marked this pull request as draft May 24, 2024 14:35
@sveneberth sveneberth added the waiting-for-changes Waiting for changes/rework from the author label May 24, 2024
@ArneGudermann
Copy link
Copy Markdown
Contributor Author

@phorward
Should I wait for #1154 ?

@phorward
Copy link
Copy Markdown
Member

@phorward Should I wait for #1154 ?

well, #1154 can't be resolved with a huger redesign. I'm quite unsure about this, as we might refactor the entire bone logic, regarding multiple and language setting. As #1154 focuses the same problem, please keep this PR for now as is.

@phorward
Copy link
Copy Markdown
Member

phorward commented Apr 3, 2025

@ArneGudermann will this PR come to end? Is it ready for reviewing?

@ArneGudermann
Copy link
Copy Markdown
Contributor Author

@phorward Should I wait for #1154 ?

well, #1154 can't be resolved with a huger redesign. I'm quite unsure about this, as we might refactor the entire bone logic, regarding multiple and language setting. As #1154 focuses the same problem, please keep this PR for now as is.

@phorward I think I should wait with this PR for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Priority: Medium This issue may be useful, and needs some attention. waiting-for-changes Waiting for changes/rework from the author

Projects

Status: Todo

Development

Successfully merging this pull request may close these issues.

3 participants