Editorial: Adds spaces in the UA pattern for Safari#280
Merged
Conversation
Member
|
Can you please make sure the commit title/body follows the guidelines? |
karlcow
changed the title
Member
Author
is it in the shape expected by the guidelines? |
miketaylr
approved these changes
Jul 25, 2025
Member
miketaylr
left a comment
miketaylr
left a comment
There was a problem hiding this comment.
LGTM - but can you remove "Editorial:" from the commit message? This is a bugfix, so it shouldn't have that.
Member
Author
|
confused. in between @miketaylr and @annevk 😝 |
Member
|
As per https://github.com/whatwg/meta/blob/main/COMMITTING.md#structure-and-conventions commit titles are not sentences and issues are to be referenced in the commit body. That's all. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Editorial: Adds spaces in the UA pattern for Safari
This fixes the pattern for Safari UA string, which was missing spaces.
Fixes #279
Preview | Diff