Skip to content

Add top-level origin check #244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
annevk wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add top-level origin check #244

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 13 additions & 5 deletions notifications.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -792,9 +792,12 @@ constructor steps are:
<p>Run these steps <a>in parallel</a>:

<ol>
<li><p>If the result of <a>getting the notifications permission state</a> is not
"<code>granted</code>", then <a>queue a task</a> to <a>fire an event</a> named
<code>error</code> on <a>this</a>, and abort these steps.
<li><p>If <a>this</a>'s <a>relevant settings object</a>'s
<a for="environment settings object">origin</a> is not <a>same origin</a> with <a>this</a>'s
<a>relevant settings object</a>'s <a for="environment">top-level origin</a> or the result of
<a>getting the notifications permission state</a> is not "<code>granted</code>", then
<a>queue a task</a> to <a>fire an event</a> named <code>error</code> on <a>this</a>, and abort
these steps.

<li><p>Run the <a for=/>notification show steps</a> for <var>notification</var>.
</ol>
Expand Down Expand Up @@ -838,8 +841,13 @@ method steps are:
<p>Run these steps <a>in parallel</a>:

<ol>
<li><p>Let <var>permissionState</var> be the result of
<a>requesting permission to use</a> "<a permission><code>notifications</code></a>".
<li><p>Let <var>permissionState</var> be "<code>denied</code>".

<li><p>If <a>this</a>'s <a>relevant settings object</a>'s
<a for="environment settings object">origin</a> is <a>same origin</a> with <a>this</a>'s
<a>relevant settings object</a>'s <a for="environment">top-level origin</a>, then set
<var>permissionState</var> to the result of <a>requesting permission to use</a>
"<a permission><code>notifications</code></a>".

<li>
<p><a>Queue a global task</a> on the <a>DOM manipulation task source</a> given <var>global</var>
Expand Down