I reviewed my old changes and merged them into the current branch#79
I reviewed my old changes and merged them into the current branch#79LordMartron94 wants to merge 23 commits intowileyyugioh:betafrom
Conversation
…LID-Refactoring
The zotmoov-wildcard is a darned BEAST to tackle. Took me an hour to figure out and refactor the *METHOD* _format_authors(authors)
The root folder of the project was a bit cluttered previously.
Large job, took multiple days...
Added some stuff to make it easier to read and maintain. Tested to work.
… into merge-old-fixes
|
https://forums.zotero.org/discussion/121226/fix-file-length-limit-ioutils?new=1 Asked for a way to configure path length limits so we can fix this in a more robust way. |
|
Wow! This is a massive pull request so please give me some time to review. One thing I noticed while skimming is that you changed |
Take your time. I haven't checked that as I didn't have that issue before, but I'll be sure to test that once I get back. Again, I also still need to incorporate the custom wildcard behavior you added in between my old fixes and now. It shouldn't be too difficult to merge those in though. |
|
Ahh I see you are working on it yourself, awesome. Apologies, have been a bit busy myself. The check for first load is smart too to resolve the issue you encountered :) |
2 participants
I primarily refactored the wildcard behavior and made a temporary fix for the path too long issues...
I will let you know once that is done.
I will also look for a way to make the path length thing more robust.
Lastly, I am looking to becoming more active in the maintaining and development of this project once again. Most notably with refactoring stuff to be easier to maintain. I might also attempt to add new features and solve bugs.