add pin for packages that exist in native repo

[silentJET85]

closes #1426

[flexiondotorg]

I think that apt pinning should only be applied for the packages that are problematic, rather than making this a default fault behaviour.

[silentJET85]

I have added a check for a variable called APT_PIN which can be set in the package definition file of a problematic package. If this is set to 1, a pin will be added. EDIT: I've changed the value from 1 to true, for clarity.

[silentJET85]

@cubic-dev-ai Can you review this?

[cubic-dev-ai]

@cubic-dev-ai Can you review this?

@silentJET85 I have started the AI code review. It will take a few minutes to complete.

[cubic-dev-ai]

2 issues found across 1 file

Confidence score: 3/5

• There is concrete regression risk in deb-get: APT_PIN is not reset per package in install/reinstall flows, so pin state can leak across packages during multi-package operations.
• Failure handling in deb-get also appears incomplete: pre-applied apt pin changes are not rolled back on install/reinstall errors, which can leave persistent pin state after unsuccessful runs.
• Given the 6–7/10 severity with high confidence, this is likely mergeable only with caution because behavior can be user-visible in package selection and future apt operations. Pay close attention to deb-get - pin state lifecycle needs reset and rollback coverage in install/reinstall paths.

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="deb-get">

<violation number="1" location="deb-get:345">
P1: `APT_PIN` is read in new install/reinstall paths but not reset per package, so pin state can leak between packages in multi-package operations.</violation>

<violation number="2" location="deb-get:346">
P2: Install/reinstall failure paths do not roll back pre-applied apt pin changes, leaving persistent pin state after unsuccessful operations.</violation>
</file>

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.}

[cubic-dev-ai]

0 issues found across 1 file (changes from recent commits).

_{Requires human review: Modifies system-level APT pinning logic and package installation flow, which impacts core functionality and system configuration.}