Conversation
There was a problem hiding this comment.
No issues found across 2 files
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Requires human review: Adding a new package definition includes shell script logic and introduces a new external dependency, which requires human verification for safety and correctness.
Since this is your first cubic review, here's how it works:
- cubic automatically reviews your code and comments on bugs and improvements
- Teach cubic by replying to its comments. cubic learns from your replies and gets better over time
- Add one-off context when rerunning by tagging
@cubic-dev-aiwith guidance or docs links (includingllms.txt) - Ask questions if you need clarification on any suggestion
silentJET85
left a comment
There was a problem hiding this comment.
Just FYI, your ${ARCH} variable is redundant. It's possible to grep for the ${HOST_ARCH} directly.
| if [ "${ACTION}" != "prettylist" ]; then | ||
| URL=$(grep -m 1 "browser_download_url.*openwork-desktop-linux-${HOST_ARCH}\.deb\"" "${CACHE_FILE}" | cut -d'"' -f4) |
There was a problem hiding this comment.
| if [ "${ACTION}" != "prettylist" ]; then | |
| URL=$(grep -m 1 "browser_download_url.*openwork-desktop-linux-${HOST_ARCH}\.deb\"" "${CACHE_FILE}" | cut -d'"' -f4) | |
| if [ "${ACTION}" != "prettylist" ]; then | |
| URL=$(grep -m 1 "browser_download_url.*openwork-desktop-linux-${HOST_ARCH}\.deb\"" "${CACHE_FILE}" | cut -d '"' -f 4) |
| get_github_releases "different-ai/openwork" "latest" | ||
| if [ "${ACTION}" != "prettylist" ]; then | ||
| URL=$(grep -m 1 "browser_download_url.*openwork-desktop-linux-${HOST_ARCH}\.deb\"" "${CACHE_FILE}" | cut -d'"' -f4) | ||
| VERSION_PUBLISHED=$(echo "${URL}" | cut -d'/' -f8 | tr -d v) |
There was a problem hiding this comment.
| VERSION_PUBLISHED=$(echo "${URL}" | cut -d'/' -f8 | tr -d v) | |
| VERSION_PUBLISHED=$( cut -d '/' -f 8 <<< "${URL//v/}") |
|
Also, the package name should be |
philclifford
left a comment
There was a problem hiding this comment.
Please rename the definition to match the name in the package
| openaudible | ||
| openrazer-meta | ||
| openrgb | ||
| openwork |
There was a problem hiding this comment.
| openwork | |
| open-work |
The definition filename and manifest entry must exactly match the application name
apt info ./openwork-desktop-linux-amd64.deb
Package: open-work
There was a problem hiding this comment.
This file must be named 'open-work'
Summary
01-main/packages/openworkdefinition for the OpenWork desktop appamd64andarm64by selecting the matching GitHub release.debassetopenworkto01-main/manifestCloses #1773