Skip to content

Add OpenWork package definition#1774

Open
YuF-9468 wants to merge 2 commits intowimpysworld:mainfrom
YuF-9468:add-openwork-package
Open

Add OpenWork package definition#1774
YuF-9468 wants to merge 2 commits intowimpysworld:mainfrom
YuF-9468:add-openwork-package

Conversation

@YuF-9468
Copy link
Copy Markdown

@YuF-9468 YuF-9468 commented Mar 8, 2026

Summary

  • add a new 01-main/packages/openwork definition for the OpenWork desktop app
  • support both amd64 and arm64 by selecting the matching GitHub release .deb asset
  • append openwork to 01-main/manifest

Closes #1773

Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Requires human review: Adding a new package definition includes shell script logic and introduces a new external dependency, which requires human verification for safety and correctness.


Since this is your first cubic review, here's how it works:

  • cubic automatically reviews your code and comments on bugs and improvements
  • Teach cubic by replying to its comments. cubic learns from your replies and gets better over time
  • Add one-off context when rerunning by tagging @cubic-dev-ai with guidance or docs links (including llms.txt)
  • Ask questions if you need clarification on any suggestion

Copy link
Copy Markdown
Contributor

@silentJET85 silentJET85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just FYI, your ${ARCH} variable is redundant. It's possible to grep for the ${HOST_ARCH} directly.

Comment on lines +4 to +5
if [ "${ACTION}" != "prettylist" ]; then
URL=$(grep -m 1 "browser_download_url.*openwork-desktop-linux-${HOST_ARCH}\.deb\"" "${CACHE_FILE}" | cut -d'"' -f4)
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if [ "${ACTION}" != "prettylist" ]; then
URL=$(grep -m 1 "browser_download_url.*openwork-desktop-linux-${HOST_ARCH}\.deb\"" "${CACHE_FILE}" | cut -d'"' -f4)
if [ "${ACTION}" != "prettylist" ]; then
URL=$(grep -m 1 "browser_download_url.*openwork-desktop-linux-${HOST_ARCH}\.deb\"" "${CACHE_FILE}" | cut -d '"' -f 4)

get_github_releases "different-ai/openwork" "latest"
if [ "${ACTION}" != "prettylist" ]; then
URL=$(grep -m 1 "browser_download_url.*openwork-desktop-linux-${HOST_ARCH}\.deb\"" "${CACHE_FILE}" | cut -d'"' -f4)
VERSION_PUBLISHED=$(echo "${URL}" | cut -d'/' -f8 | tr -d v)
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
VERSION_PUBLISHED=$(echo "${URL}" | cut -d'/' -f8 | tr -d v)
VERSION_PUBLISHED=$( cut -d '/' -f 8 <<< "${URL//v/}")

@silentJET85
Copy link
Copy Markdown
Contributor

Also, the package name should be open-work instead of openwork. That's probably why the tests failed.

dpkg -I openwork-desktop-linux-amd64.deb 
 new Debian package, version 2.0.
 size 211021030 bytes: control archive=654 bytes.
     195 bytes,     9 lines      control
     742 bytes,    11 lines      md5sums
 Package: open-work
 Version: 0.11.191
 Architecture: amd64
 Installed-Size: 550737
 Maintainer: Different AI
 Priority: optional
 Depends: libwebkit2gtk-4.1-0, libgtk-3-0
 Description: OpenWork
  (none)

Copy link
Copy Markdown
Member

@philclifford philclifford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rename the definition to match the name in the package

openaudible
openrazer-meta
openrgb
openwork
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
openwork
open-work

The definition filename and manifest entry must exactly match the application name

 apt info ./openwork-desktop-linux-amd64.deb 
Package: open-work

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file must be named 'open-work'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

App Request: OpenWork

3 participants