Export Windows Function Wrappers#958
Merged
padelsbach merged 1 commit intowolfSSL:masterfrom Apr 28, 2026
Merged
Conversation
Retag the WS_FindFirstFileA() and WS_FindNextFileA() functions as WOLFSSH_API, not just local. They are used in the example SFTP client.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the symbol visibility of Windows directory iteration wrappers so they can be linked from external consumers (notably the example SFTP client) when building wolfSSH as a shared library/DLL.
Changes:
- Change
WS_FindFirstFileA()andWS_FindNextFileA()declarations fromWOLFSSH_LOCALtoWOLFSSH_APIin the public port header.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
padelsbach
approved these changes
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Retag the WS_FindFirstFileA() and WS_FindNextFileA() functions as WOLFSSH_API, not just local. They are used in the example SFTP client.