[libsigcplusplus] Add 2.12.1, + some formatting changes#9879
Merged
waruqi merged 3 commits intoxmake-io:devfrom May 6, 2026
Merged
[libsigcplusplus] Add 2.12.1, + some formatting changes#9879waruqi merged 3 commits intoxmake-io:devfrom
waruqi merged 3 commits intoxmake-io:devfrom
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the libsigcplusplus package to use release download URLs, updates version hashes, and adds version 2.12.1. It also introduces a dynamic on_load block to set include directories based on the package's major version. A potential issue was identified where non-semver versions could cause a Lua error during string concatenation, and a more robust implementation was suggested to handle these cases.
This fixes errors where some builds stop due to not finding doxygen.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-Add support for libsigcplusplus 2.12.1.
-Some formatting changes to libsigcplusplus' xmake.lua:
--Add an on_load block to handle include path for 2.x.x and 3.x.x versions differently.
--Change the add_url link, and the sha256 for all versions of libsigcplusplus
After first adding the 2.12.1 version and sha256, I got an error relating to an untracked folder from meson, which subsequently made xmake errors:
sigc++\meson.build:155:19: ERROR: File ../untracked/sigc++/adaptors/lambda/lambda.cc does not exist.Looking into the cause, found some insightful sources:
At least for the versions in the build files, doesn't seem like there's a need to define maintainer-mode.
Tested all 4 versions locally (Windows). Don't know if my changes adds support for any more platforms.
This closes #9852 .