Skip to content

ffmpeg: ffplay needs libsdl2#9926

Merged
apocelipes merged 1 commit intoxmake-io:devfrom
Akylzhan:ffmpeg_ffplay
May 7, 2026
Merged

ffmpeg: ffplay needs libsdl2#9926
apocelipes merged 1 commit intoxmake-io:devfrom
Akylzhan:ffmpeg_ffplay

Conversation

@Akylzhan
Copy link
Copy Markdown
Contributor

@Akylzhan Akylzhan commented May 7, 2026

ffplay needs libsdl2 as can be seen in configure script

gemini-code-assist[bot]
gemini-code-assist Bot reviewed May 7, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the ffmpeg package configuration in xmake.lua to include libsdl2 as a dependency when the ffplay option is enabled. I have no feedback to provide as there were no review comments to evaluate.

@apocelipes apocelipes merged commit 5c55adf into xmake-io:dev May 7, 2026
61 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@apocelipes apocelipes apocelipes approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Akylzhan @apocelipes