🧹 cleanup: Remove unused parseLog function and improve log parsing logic

[Asutorufa]

This change improves code health by removing dead code and improving the remaining log parsing logic. The unused manual parser was replaced by the more robust regex-based parser, which was renamed from parseLogv2 to parseLog. A bug in the fallback case (matching logcat -v time format) was also fixed. Unit tests were added to ensure both common logcat formats are correctly parsed.

---

PR created automatically by Jules for task 4129727778459587503 started by @Asutorufa

[google-labs-jules]

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.

---

For security, I will only act on instructions from the user who triggered this task.

[gemini-code-assist]

Summary of Changes

Hello @Asutorufa, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the robustness and maintainability of the log parsing functionality. By consolidating the parsing logic into a single, regex-based approach and removing a redundant manual parser, the codebase becomes cleaner and less prone to errors. The inclusion of dedicated unit tests provides strong assurance that various log formats are handled correctly, preventing regressions and improving overall reliability.

Highlights

• Code Cleanup: The unused manual log parsing function (parseLog) has been removed, improving code health and reducing redundancy.
• Improved Log Parsing Logic: The more robust regex-based log parser (parseLogv2) has been renamed to parseLog and is now the sole log parsing mechanism. A bug in the fallback case for logcat -v time format parsing was also fixed, ensuring correct extraction of log level and time.
• Unit Tests Added: New unit tests have been introduced to validate the parseLog function's ability to correctly parse common logcat formats (threadtime and time) and handle unknown log lines.

Changelog

• app/src/main/kotlin/io/github/asutorufa/yuhaiin/compose/Logcat.kt
  • Renamed parseLogv2 to parseLog to reflect its new role as the primary log parsing function.
  • Corrected a bug in the parseLog function where the wrong regex group was used to extract the log level and time for logcat -v time format.
  • Removed the old, manual parseLog function, which was no longer in use.
  • Updated the call site for the log parsing function from parseLogv2 to parseLog.
• app/src/test/kotlin/io/github/asutorufa/yuhaiin/compose/LogcatTest.kt
  • Added a new test file to include unit tests for the parseLog function.
  • Implemented testParseThreadTime to verify parsing of logcat lines in threadtime format.
  • Implemented testParseTime to verify parsing of logcat lines in time format.
  • Implemented testParseUnknown to ensure the parser gracefully handles unrecognised log line formats.

Activity

• The pull request was automatically created by Jules for task 4129727778459587503, initiated by @Asutorufa.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

The pull request successfully cleans up the log parsing logic by removing the manual parser and consolidating on the regex-based approach. It also fixes a bug in the fallback parsing case for the time format where the wrong matcher and group indices were being used. The addition of unit tests ensures that both common logcat formats are correctly handled.

[gemini-code-assist]

The logic for mapping log level characters (V, D, I, W, E, F) to LogLevel enum values is duplicated in both the THREADTIME_LINE and TIME_LINE parsing blocks. Consider refactoring this into a helper function to improve maintainability and reduce duplication.

Example:

private fun String?.toLogLevel(): LogLevel = when (this) {
    "V", "D" -> LogLevel.DEBUG
    "I" -> LogLevel.INFO
    "W" -> LogLevel.WARN
    "E", "F" -> LogLevel.ERROR
    else -> LogLevel.INFO
}