Merged
Conversation
yutannihilation
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #442
Problem
On macOS, downstream packages get this linker warning during
R CMD check:unwind_protect_wrapper.ois compiled by thecccrate in savvy'sbuild.rs. WhenMACOSX_DEPLOYMENT_TARGETis unset,ccfalls back toxcrun --show-sdk-version(e.g. 26.2), which mismatches R's deployment target (e.g. 15.0).So far, downstream packages have worked around this in their own
configurescript (cf. yutannihilation/string2path#202, yutannihilation/string2path#208). It would be nicer to fix it once in savvy itself.Fix
Propagate
MACOSX_DEPLOYMENT_TARGETjust the same as yutannihilation/string2path#208 does