DYN-8338 Enable a new Marker on Input and Output Port for Launching Node AutoComplete by johnpierson · Pull Request #15947 · DynamoDS/Dynamo

johnpierson · 2025-03-19T12:28:27Z

Purpose

This PR adds a new marker that appears on output ports during hover for node autocomplete. If approved, this would replace the double click paradigm and decouple autocomplete from wire connection interference.

Declarations

Check these if you believe they are true

The codebase is in a better state after this PR
Is documented according to the standards
The level of testing this PR includes is appropriate
User facing strings, if any, are extracted into *.resx files
All tests pass using the self-service CI.
Snapshot of UI changes, if any.
Changes to the API follow Semantic Versioning and are documented in the API Changes document.
This PR modifies some build requirements and the readme is updated
This PR contains no files larger than 50 MB

Release Notes

Introduction of a new in canvas marker (outside the port). This new marker, the Node Autocomplete Marker, allows for launching of the node autocomplete service.

Reviewers

@QilongTang @BogdanZavu @chubakueno @Jingyi-Wen

FYIs

@Amoursol @mjkkirschner

johnpierson · 2025-03-19T12:31:06Z

Related to DYN-8338 and DYN-8398

github-actions

See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-8338

johnpierson · 2025-03-19T22:28:43Z

Oh cool. Let me get that integrated.

…

On Wed, Mar 19, 2025 at 4:20 PM Bogdan Zavu ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In src/DynamoCoreWpf/UI/Themes/Modern/OutPorts.xaml <#15947 (comment)>: > -  - <Grid.InputBindings> - <MouseBinding Command="{Binding Path=NodeAutoCompleteCommand}" MouseAction="LeftDoubleClick" /> - </Grid.InputBindings> +  + <Grid That is a separate control , not connected to the node view. But I think I have something at least it seems to work on my end as expected. So the trick is to process the event in our sparkling bubble and prevent the mouse event from propagating to the parent control and launch the other command. So I have this : <Border x:Name="NodeAutoCompleteMarker" Grid.Column="2" Margin="0,0,-20,0" Cursor="Hand" CornerRadius="10" Height="18px" Width="18px" VerticalAlignment="Center" HorizontalAlignment="Right" Background="#D5BCF7" IsHitTestVisible="True" SnapsToDevicePixels="True" Visibility="Visible"> <TextBlock TextAlignment="Center" FontSize="11" VerticalAlignment="Center" HorizontalAlignment="Center" >✨</TextBlock> <interactivity:Interaction.Triggers> <interactivity:EventTrigger EventName="PreviewMouseDown"> <interactivity:InvokeCommandAction Command="{Binding NodeAutoCompleteCommand}" PassEventArgsToCommand="True"/> </interactivity:EventTrigger> </interactivity:Interaction.Triggers> </Border> And now in NodeAutoCompleteCommand we receive the mouse arguments and we can prevent the bubbling. private bool CanAutoComplete(object parameter) { MouseButtonEventArgs evArgs = parameter as MouseButtonEventArgs; evArgs.Handled = true; I think if we integrate the above with the rest of your changes we should be good. — Reply to this email directly, view it on GitHub <#15947 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADYD5VCHJAKEFJAFK225PO32VHURNAVCNFSM6AAAAABZKWIN5SVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDOMBQGQYTCMRSGM> . You are receiving this because you authored the thread.Message ID: ***@***.***>

QilongTang · 2025-03-20T13:58:32Z


+        private void TryShowAutoCompleteMarker()
+        {
+            //show the node autocomplete marker if available, skip codeblocks and watch nodes


BogdanZavu · 2025-03-20T14:01:31Z

In NodeAutoCompleteSearchControl.xaml
EventSetter Event="PreviewMouseLeftButtonUp"Handler="OnMouseLeftButtonUp"
Let's replace this with MouseLeftButtonDown - the reason is ButtonUp escapes sometimes (we are only preventing LeftButtonDown from propagation ) and it can trigger node placement accidentally from the NDA popup list.

BogdanZavu · 2025-03-20T14:29:50Z

Let's add this to the inports as well.

QilongTang · 2025-03-20T15:12:22Z

-            <!--  Bind NodeAutoComplete to double left click  -->
-            <Grid.InputBindings>
-                <MouseBinding Command="{Binding Path=NodeAutoCompleteCommand}" MouseAction="LeftDoubleClick" />
-            </Grid.InputBindings>


@BogdanZavu @johnpierson Should we hold on touching the behavior for regular autocomplete yet? Only apply to cluster autocomplete for now? We can use a dedicated command for cluster autocomplete if needed

Not really, I think the change is solid. So let's go ahead with the general improvement. We can ask for some help with testing from @jnealb once it's in.

QilongTang · 2025-03-21T02:04:34Z

Buildtime errors:
D:\a\Dynamo\Dynamo\Dynamo\src\DynamoCoreWpf\ViewModels\Core\PortViewModel.cs(110,13): error RS0016: Symbol 'NodeAutoCompleteMarkerVisible.get' is not part of the declared public API (https://github.com/dotnet/roslyn-analyzers/blob/main/src/PublicApiAnalyzers/PublicApiAnalyzers.Help.md) [D:\a\Dynamo\Dynamo\Dynamo\src\DynamoCoreWpf\DynamoCoreWpf.csproj]
D:\a\Dynamo\Dynamo\Dynamo\src\DynamoCoreWpf\ViewModels\Core\PortViewModel.cs(111,13): error RS0016: Symbol 'NodeAutoCompleteMarkerVisible.set' is not part of the declared public API (https://github.com/dotnet/roslyn-analyzers/blob/main/src/PublicApiAnalyzers/PublicApiAnalyzers.Help.md) [D:\a\Dynamo\Dynamo\Dynamo\src\DynamoCoreWpf\DynamoCoreWpf.csproj]

johnpierson · 2025-03-21T12:00:40Z

~~I moved that method to internal. So hopefully that works @QilongTang~~
That didn't work, so I might have to add this new method to PublicApi?

QilongTang · 2025-03-21T15:06:16Z

+                        <interactivity:InvokeCommandAction Command="{Binding NodeAutoCompleteCommand}" PassEventArgsToCommand="True"/>
+                    </interactivity:EventTrigger>
+                </interactivity:Interaction.Triggers>
+            </Border>


@BogdanZavu @johnpierson Would you remind me this would not make this part of every port at the view initialization right? Just thinking about performance impact

So we only added one border - while collapsed this will not participate in the rendering , sizing recalculation etc so performance should remain the same. Same thing for the highlight.

QilongTang

Other than two comments, LGTM

BogdanZavu · 2025-03-21T15:16:45Z

Cool! LGTM! Let's add those color defines and I think we're good! *✧

- Add marker to output port - Hook marker to node autocomplete command (single click) - Enable visibility when no connection exists (Apologies for this all being one commit as I had to refork, rebranch and all sorts of mess because of a merge conflict with a previous PR)

Tie Node AutoComplete Marker to be visible only when it is enabled in preferences

… is frozen/transient

@chubakueno

FYI @chubakueno

Move NodeAutoCompleteMarkerVisible to internal

Disable node autocomplete marker on Python nodes.

BogdanZavu · 2025-03-21T19:04:58Z

        private const double autocompletePopupSpacing = 2.5;
        private const double proxyPortContextMenuOffset = 20;
        internal bool inputPortDisconnectedByConnectCommand = false;
+        private bool nodeAutoCompleteMarkerVisible;


@johnpierson guessing the failure reason - let's initialize this with false. I suspect during tests is true and the tests record the control no

It is because the control is a child element of the port. So now it reports back 9 for this node when it was previously 6.

QilongTang · 2025-03-21T19:17:35Z

Sorry @johnpierson I introduced merge conflicts.. Addressed for you!

johnpierson · 2025-03-21T19:20:00Z

…hnpierson/Dynamo into DYN8338_AddAutoCompleteMarker

Hide the autocomplete marker while the node is moving

johnpierson · 2025-03-21T20:53:51Z

I tested the 1 failure now locally and it seems to be passing. This should be good to go @QilongTang

BogdanZavu · 2025-03-21T20:56:27Z

There is 1 failed test but I think it's not related to this change and it passes for me locally.
So I think we're good to go with this one @johnpierson @QilongTang

johnpierson · 2025-03-21T21:07:30Z

@BogdanZavu - Last time I merged a PR, I did it early by accident so if you guys want to do it. :)

…nching Node AutoComplete (DynamoDS#15947)" This reverts commit 68ae401.

johnpierson changed the title ~~[DYN-8338] Enable a new Marker on Output Port for Launching Node AutoComplete~~ DYN-8338 Enable a new Marker on Output Port for Launching Node AutoComplete Mar 19, 2025

github-actions Bot reviewed Mar 19, 2025

View reviewed changes

johnpierson requested review from BogdanZavu and QilongTang March 19, 2025 12:58

BogdanZavu reviewed Mar 19, 2025

View reviewed changes

Comment thread src/DynamoCoreWpf/Views/Core/NodeView.xaml.cs Outdated

BogdanZavu reviewed Mar 19, 2025

View reviewed changes

Comment thread src/DynamoCoreWpf/UI/Themes/Modern/OutPorts.xaml Outdated

BogdanZavu reviewed Mar 19, 2025

View reviewed changes

Comment thread src/DynamoCoreWpf/UI/Themes/Modern/OutPorts.xaml Outdated

johnpierson requested a review from BogdanZavu March 20, 2025 13:07

BogdanZavu reviewed Mar 20, 2025

View reviewed changes

Comment thread src/DynamoCoreWpf/ViewModels/Core/PortViewModel.cs Outdated

QilongTang reviewed Mar 20, 2025

View reviewed changes

Comment thread src/DynamoCoreWpf/Views/Core/NodeView.xaml.cs Outdated

QilongTang reviewed Mar 20, 2025

View reviewed changes

johnpierson changed the title ~~DYN-8338 Enable a new Marker on Output Port for Launching Node AutoComplete~~ DYN-8338 Enable a new Marker on Input and Output Port for Launching Node AutoComplete Mar 20, 2025

QilongTang reviewed Mar 21, 2025

View reviewed changes

Comment thread src/DynamoCoreWpf/UI/Themes/Modern/InPorts.xaml Outdated

QilongTang reviewed Mar 21, 2025

View reviewed changes

Comment thread src/DynamoCoreWpf/UI/Themes/Modern/OutPorts.xaml Outdated

QilongTang reviewed Mar 21, 2025

View reviewed changes

QilongTang approved these changes Mar 21, 2025

View reviewed changes

BogdanZavu approved these changes Mar 21, 2025

View reviewed changes

johnpierson added 5 commits March 21, 2025 11:22

Update NodeView.xaml.cs

e146fc5

Tie Node AutoComplete Marker to be visible only when it is enabled in preferences

Cleanup xaml

54f4483

Diabled auto complete marker if connectors are being created, or node…

3b1368c

… is frozen/transient

Name grid for potential hosting of flyout for DNA.

4a9a8cd

FYI @chubakueno

johnpierson added 13 commits March 21, 2025 11:22

Update OutPorts.xaml

0c7fcef

Update NodeView.xaml.cs

1a20d84

Changes for mouse handler on autocomplete search control

938ae7d

Update OutPorts.xaml

ce6a589

Update OutPorts.xaml

80e99aa

Add Node Autcomplete Marker to Input Ports

490a32b

Update PortViewModel.cs

68b2e89

Move NodeAutoCompleteMarkerVisible to internal

NodeAutoCompleteMarkerVisible API Changes

cee845a

Update PortViewModel.cs

4b61721

Update PublicAPI.Unshipped.txt

b13f9c8

Update PublicAPI.Unshipped.txt

4c5e461

Remove dropshadow

ad65d34

Update NodeView.xaml.cs

bd4b02f

Disable node autocomplete marker on Python nodes.

johnpierson force-pushed the DYN8338_AddAutoCompleteMarker branch from ef27dc1 to bd4b02f Compare March 21, 2025 17:23

johnpierson added 2 commits March 21, 2025 11:27

Merge branch 'master' into DYN8338_AddAutoCompleteMarker

2433f52

Update InPorts.xaml

98beba8

BogdanZavu reviewed Mar 21, 2025

View reviewed changes

Merge branch 'master' into DYN8338_AddAutoCompleteMarker

491faea

johnpierson added 3 commits March 21, 2025 13:24

Switch Node AutoComplete Marker to Label Object

4cd302b

Merge branch 'DYN8338_AddAutoCompleteMarker' of https://github.com/jo…

6f43adf

…hnpierson/Dynamo into DYN8338_AddAutoCompleteMarker

Update NodeView.xaml.cs

52b2541

Hide the autocomplete marker while the node is moving

BogdanZavu merged commit 68ae401 into DynamoDS:master Mar 21, 2025
25 of 26 checks passed

johnpierson deleted the DYN8338_AddAutoCompleteMarker branch March 21, 2025 21:11

johnpierson mentioned this pull request Mar 24, 2025

[DYN-8338] Move Auto-Complete Marker Triggering to ViewModel Instead of Codebehind #15969

Merged

9 tasks

johnpierson added a commit to johnpierson/Dynamo that referenced this pull request Mar 27, 2025

Revert "DYN-8338 Enable a new Marker on Input and Output Port for Lau…

d90d0d2

…nching Node AutoComplete (DynamoDS#15947)" This reverts commit 68ae401.

Conversation

johnpierson commented Mar 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Purpose

Declarations

Release Notes

Reviewers

FYIs

Uh oh!

johnpierson commented Mar 19, 2025

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

johnpierson commented Mar 19, 2025 via email

Uh oh!

Uh oh!

QilongTang Mar 20, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

BogdanZavu commented Mar 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

BogdanZavu commented Mar 20, 2025

Uh oh!

QilongTang Mar 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

BogdanZavu Mar 20, 2025

Choose a reason for hiding this comment

Uh oh!

QilongTang commented Mar 21, 2025

Uh oh!

johnpierson commented Mar 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

QilongTang Mar 21, 2025

Choose a reason for hiding this comment

Uh oh!

BogdanZavu Mar 21, 2025

Choose a reason for hiding this comment

Uh oh!

QilongTang left a comment

Choose a reason for hiding this comment

Uh oh!

BogdanZavu commented Mar 21, 2025

Uh oh!

BogdanZavu Mar 21, 2025

Choose a reason for hiding this comment

Uh oh!

johnpierson Mar 21, 2025

Choose a reason for hiding this comment

Uh oh!

QilongTang commented Mar 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

johnpierson commented Mar 21, 2025

Uh oh!

johnpierson commented Mar 21, 2025

Uh oh!

BogdanZavu commented Mar 21, 2025

Uh oh!

johnpierson commented Mar 21, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

johnpierson commented Mar 19, 2025 •

edited

Loading

BogdanZavu commented Mar 20, 2025 •

edited

Loading

QilongTang Mar 20, 2025 •

edited

Loading

johnpierson commented Mar 21, 2025 •

edited

Loading

QilongTang commented Mar 21, 2025 •

edited

Loading