[DYN-8596] Curve Mapper : Generate warnings#16141
[DYN-8596] Curve Mapper : Generate warnings#16141reddyashish merged 3 commits intoDynamoDS:masterfrom
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-8596
| [ArbitraryDimensionArrayImport] object minY, | ||
| [ArbitraryDimensionArrayImport] object maxY, | ||
| List<double> pointsCount, | ||
| [ArbitraryDimensionArrayImport] object pointsCount, |
There was a problem hiding this comment.
This is an API break.
There was a problem hiding this comment.
latest commit should resolve this
| /// The sine wave is defined by two control points and follows a trigonometric function. | ||
| /// </summary> | ||
|
|
||
| [IsVisibleInDynamoLibrary(false)] |
There was a problem hiding this comment.
Why add this attribute explicitly for all curves?
There was a problem hiding this comment.
because they show in search
There was a problem hiding this comment.
Were they showing up before as well? Or some change in this PR that affects it?
There was a problem hiding this comment.
They must have been there before
There was a problem hiding this comment.
hmm only showing up in the incanvas search, not in the library component. Good that we are hiding them now.
|
|
||
| // Preserve original API signature by wrapping to internal object-based version | ||
| // This allows handling of both scalars and lists while avoiding replication | ||
| private static List<double> PrivateCalculateValuesX( |
There was a problem hiding this comment.
Works fine but a better way to be to add this as a new public/internal method with 'pointsCount' as '[ArbitraryDimensionArrayImport] object' and add a obsolete tag to the old method(if that is not going to be used anymore). Less code to maintain.
There was a problem hiding this comment.
Please check latest commit
| </data> | ||
| </root> | ||
| <data name="CurveMapperEqualMinMaxWarning" xml:space="preserve"> | ||
| <value>• Min and Max values must not be the same.</value> |
There was a problem hiding this comment.
Helena suggested to change this message to "Min and Max values must be different.". Can you make that change in the other Curvemapper PR
|
/cherrypick |
(cherry picked from commit 51ab6d6)
|
Successfully created backport PR for |
3 participants
Purpose
This PR addresses DYN-8596 , along with several related discussions about the types of warnings generated by the CurveMapper node.
As discussed, the node's info bubble should display a single consolidated warning that summarizes any issues related to the input ports. This improves clarity and avoids overwhelming the user with multiple individual messages.
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Curve Mapper now generates a consolidated warning message based on its input values.
Reviewers
@reddyashish
@zeusongit
FYIs
@dnenov
@achintyabhat