Fix dark mode on Teacher Login and adjust login container dimensions#296
Open
Anuj-verse wants to merge 2 commits intoEswaramuthu:mainfrom
Open
Fix dark mode on Teacher Login and adjust login container dimensions#296Anuj-verse wants to merge 2 commits intoEswaramuthu:mainfrom
Anuj-verse wants to merge 2 commits intoEswaramuthu:mainfrom
Conversation
|
Automatic Review Skipped Too many files for automatic review. If you would still like a review, you can trigger one manually by commenting: |
|
@Anuj-verse is attempting to deploy a commit to the 007's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This PR addresses two main UI issues on the login pages:
Teacher Login Dark Mode Fix:
Removed the extra, conflicting inline script for the dark mode toggle in templates/teacher.html.
The teacher login page now correctly uses the global dark mode logic from script.js, matching the behavior of the student login page and preventing local state conflicts.
Login Container Sizing Fix:
Fixed the sizing of the login forms without breaking the layout of the home page and other pages.
Instead of altering the globally used .container class, added specific styling for the .login-container class in static/styles.css.
The login forms now have proper dimensions (max-width: 400px, width: 100%) ensuring a consistent and responsive appearance without affecting the widths of other components across the site.
Changes Made:
Modified templates/teacher.html to remove inline theming script.
Modified static/styles.css to add scoped .login-container dimensions.
before
after