chore: Add logs when a suggestion creation fails#984
Merged
Erethon merged 1 commit intoNixOS:mainfrom Apr 9, 2026
Merged
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Erethon
force-pushed
the
suggestion-log-fails
branch
from
f32c314 to
3128a77
Compare
Collaborator
Author
|
Didn't mean to self-merge without a proper review, I expected the merge queue to wait for it to be approved before actually merging it :/ |
| suggestion.save() | ||
| undo_status_target = None # We disable the undo button in case we have published. There is no turning back. | ||
| except Exception: | ||
| logger.exception("Failed to publish suggestion %d", suggestion_id) |
Collaborator
There was a problem hiding this comment.
Shouldn't we actually log an error (or equivalent) such that we get a notification? Not being able to publish is pretty much an outage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #982, it would be nice to know why suggestion creation failed in this case.