Skip to content

chore: Add logs when a suggestion creation fails #984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Erethon merged 1 commit into from
Apr 9, 2026
Merged

chore: Add logs when a suggestion creation fails #984

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/webview/suggestions/views/status.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,7 @@
suggestion.save()
undo_status_target = None # We disable the undo button in case we have published. There is no turning back.
except Exception:
logger.exception("Failed to publish suggestion %d", suggestion_id)

Check warning

Code scanning / CodeQL

Log Injection Medium

This log entry depends on a
user-provided value
Loading
.
Comment thread
Erethon marked this conversation as resolved.
Dismissed
Copy link
Copy Markdown
Collaborator

@fricklerhandwerk fricklerhandwerk Apr 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we actually log an error (or equivalent) such that we get a notification? Not being able to publish is pretty much an outage.

return self._handle_error(
request, suggestion_context, "Unable to publish this suggestion"
)
Expand Down