refactor(route_handler): remove LC specific functions from route handler#835
Open
mkquda wants to merge 1 commit intoautowarefoundation:mainfrom
Open
Conversation
mkquda
requested review from
a team,
go-sakayori,
kosuke55,
rej55,
soblin,
takayuki5168 and
zulfaqar-azmi-t4
as code owners
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
mkquda
added
the
run:build-and-test-differential
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #835 +/- ##
==========================================
- Coverage 50.73% 50.73% -0.01%
==========================================
Files 348 350 +2
Lines 22533 22521 -12
Branches 10071 10056 -15
==========================================
- Hits 11433 11426 -7
+ Misses 10001 10000 -1
+ Partials 1099 1095 -4
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
zulfaqar-azmi-t4
approved these changes
Feb 9, 2026
Signed-off-by: Mohammad <alqudah.mohammad@tier4.jp>
mkquda
force-pushed
the
quda/remove-LC-specific-functions-from-route-handler
branch
from
2c638a2 to
fea1945
Compare
soblin
requested changes
Mar 5, 2026
| const lanelet::ConstLanelets & lanelet_sequence, | ||
| const size_t piecewise_waypoints_lanelet_sequence_index, | ||
| const bool is_removing_direction_forward) const; | ||
| std::optional<lanelet::ConstLanelet> getLaneChangeTarget( |
Contributor
There was a problem hiding this comment.
please add [[deprecated]] and keep the functions.
Since we're releasing apt packages, we must keep those functions for a while (I'll announce when to delete them internally)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR removes functions that are specific to
lane_change_modulefrom route handler, the deleted functions is replaced by equivalent logic withlane_change_moduleutils in the following PR:autowarefoundation/autoware_universe#12039
Related links
Parent Issue:
How was this PR tested?
Notes for reviewers
merge after autowarefoundation/autoware_universe#12039
Interface changes
None.
Effects on system behavior
None.