Open
Conversation
- adds comments - consistent conventions - help parity with bash
as `run` better implies the outputs are visible
it now outputs visible errors on mismatches this was able to catch a mismatch in `stdinargs.bash` the code has also been reworked to be more understandable and less redundant finally it fixes a latent bug where the prior use of `segments[*]` produced invalid outputs as segment indexes are for segments, not for the concat string
adds a `EVAL_TESTER_ADD_TRAILING_NEWLINES_TO_SPECIFIED_EXPECTATIONS` env variable to make this easier, applied to all `is-fs-tests.bash` sourcers also some minor linting and spellchecks
/ref 96e4a8f STDIN should not have had `original_output_value` applied
elements are now inline, which creates intuitive output for exact mode - `expected` output now called `expect` for alignment with `actual` this made it easier to fix `read-key` tests for exactness
this is better, as `expected` is better than `expect` this mad it easier to resolve the `echo-min` exactness failures
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
breaking changes:
eval-testerand__dono longer strip trailing newlines, and the ability to so so has been removed; tests expected outputs must be updated