Skip to content

fix(extensions): 修复插件最新版查询#63

Merged
yokowu merged 1 commit intochaitin:mainfrom
yokowu:fix-extension-latest
Jul 9, 2025
Merged

fix(extensions): 修复插件最新版查询#63
yokowu merged 1 commit intochaitin:mainfrom
yokowu:fix-extension-latest

Conversation

@yokowu
Copy link
Copy Markdown
Collaborator

@yokowu yokowu commented Jul 9, 2025

No description provided.

@yokowu yokowu merged commit 51fbfae into chaitin:main Jul 9, 2025
2 checks passed
@yokowu yokowu deleted the fix-extension-latest branch July 9, 2025 03:20
@safe1ine
Copy link
Copy Markdown
Collaborator

@MonkeyCode-AI 来 review

Copy link
Copy Markdown
Contributor

@MonkeyCode-AI MonkeyCode-AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request 概述

  • 这个PR修改了扩展仓库的Latest方法实现,从使用Only(ctx)改为使用All(ctx)并手动处理空结果情况。这样可以更明确地处理没有找到扩展的情况,提高了代码的健壮性。

Pull Request 变更详情

文件路径 变更类型 变更内容
backend/internal/extension/repo/extension.go 修改 修改Latest方法实现,改进错误处理和空结果处理

if err != nil {
return nil, err
}
if len(es) == 0 {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

在修改后的代码中,虽然添加了对空结果的处理,但使用fmt.Errorf创建错误信息不是最佳实践。应该定义一个特定的错误类型或使用项目中已有的错误码。

Suggested change
if len(es) == 0 {
// 定义一个特定的错误变量
var ErrExtensionNotFound = errors.New("extension not found")
// 在Latest方法中使用这个错误变量
if len(es) == 0 {
return nil, ErrExtensionNotFound
}

@MonkeyCode-AI
Copy link
Copy Markdown
Contributor

⏳ MonkeyCode-AI 正在分析,请稍等片刻...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants