Skip to content

fix(extensions): 修复插件最新版查询 #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yokowu merged 1 commit into from
Jul 9, 2025
+10 −2
Merged

fix(extensions): 修复插件最新版查询 #63

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions backend/internal/extension/repo/extension.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ package repo

import (
"context"
"fmt"

"entgo.io/ent/dialect/sql"

Expand All @@ -22,11 +23,18 @@ func NewExtensionRepo(db *db.Client) domain.ExtensionRepo {

// Latest implements domain.ExtensionRepo.
func (e *ExtensionRepo) Latest(ctx context.Context) (*db.Extension, error) {
return e.db.Extension.
es, err := e.db.Extension.
Query().
Order(extension.ByCreatedAt(sql.OrderDesc())).
Limit(1).
Only(ctx)
All(ctx)
if err != nil {
return nil, err
}
if len(es) == 0 {
Copy link
Copy Markdown
Contributor

@MonkeyCode-AI MonkeyCode-AI Sep 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

在修改后的代码中，虽然添加了对空结果的处理，但使用fmt.Errorf创建错误信息不是最佳实践。应该定义一个特定的错误类型或使用项目中已有的错误码。

Suggested change
if len(es) == 0 {
// 定义一个特定的错误变量
var ErrExtensionNotFound = errors.New("extension not found")
// 在Latest方法中使用这个错误变量
if len(es) == 0 {
return nil, ErrExtensionNotFound
}

return nil, fmt.Errorf("extension not found")
}
return es[0], nil
}

// Save implements domain.ExtensionRepo.
Expand Down
Loading