chore: deprecate String.Legacy and Substring.Raw.Legacy declarations#1736
Merged
chore: deprecate String.Legacy and Substring.Raw.Legacy declarations#1736
String.Legacy and Substring.Raw.Legacy declarations#1736Conversation
This PR adds `@[deprecated "Use the new `String` API." (since := "2026-03-26")]` to every declaration in the `String.Legacy` and `Substring.Raw.Legacy` namespaces. Uses `set_option linter.deprecated false` at the section level in both `Legacy.lean` and `Lemmas.lean` to suppress internal usage warnings. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
github-actions
bot
added
the
awaiting-review
mathlib-nightly-testing bot
added a commit
to leanprover-community/mathlib4-nightly-testing
that referenced
this pull request
Mar 26, 2026
fgdorais
approved these changes
Mar 31, 2026
github-actions
bot
removed
the
awaiting-review
This was referenced Apr 1, 2026
Contributor
|
I believe this PR broke mathlib and was erroneously merged. This is causing issues with other PRs. |
Contributor
|
At the very least, I do not understand why it was merged if mathlib's build was not confirmed. |
fgdorais
added a commit
that referenced
this pull request
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds
@[deprecated "Use the newStringAPI." (since := "2026-03-26")]to every declaration in theString.LegacyandSubstring.Raw.Legacynamespaces.Uses
set_option linter.deprecated falseat the section level in bothLegacy.leanandLemmas.leanto suppress internal usage warnings.🤖 Prepared with Claude Code