[Merged by Bors] - feat(CI): On bors r/d-, remove ready-to-merge and delegated labels#21636
Closed
[Merged by Bors] - feat(CI): On bors r/d-, remove ready-to-merge and delegated labels#21636
bors r/d-, remove ready-to-merge and delegated labels#21636Conversation
github-actions
bot
added
the
CI
PR summary 2a97943940Import changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for No changes to technical debt.You can run this locally as
|
grunweg
reviewed
Feb 10, 2025
Contributor
grunweg
left a comment
grunweg
left a comment
There was a problem hiding this comment.
Looks plausible, thanks! (I have only compared this to existing code, somebody else should double-check. @bryangingechen Do you feel like taking a look?)
maintainer merge
|
🚀 Pull request has been placed on the maintainer queue by grunweg. |
github-actions
bot
added
the
maintainer-merge
Contributor
|
bors merge |
ghost
added
ready-to-merge
mathlib-bors bot
pushed a commit
that referenced
this pull request
Feb 10, 2025
…els (#21636) This removes the labels also on `bors d-`, even though this is not a `bors` command. [Zulip discussion](https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/queueboard/near/498700175)
Contributor
|
This is already about to be merged so I won't take it off, but support for the synonym |
Contributor
Author
|
Bryan, good point! I will wait for this to merge, test it as is and then PR the |
Contributor
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
bors r/d-, remove ready-to-merge and delegated labelsbors r/d-, remove ready-to-merge and delegated labels
mathlib-bors bot
pushed a commit
that referenced
this pull request
Feb 10, 2025
Reported on #21636 This makes the older regex be more restrictive, since it now should distinguish between `bors d+`/`bors delegate` on one hand and `bors d-` on the other. Also fixes a bug in the previous PR: I had forgotten to "close" the `sed` call.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes the labels also on
bors d-, even though this is not aborscommand.Zulip discussion