Skip to content

[Merged by Bors] - fix: rename file to please_merge_master#21675

Closed
adomani wants to merge 1 commit intomasterfrom
adomani/please_merge_mastr
Closed

[Merged by Bors] - fix: rename file to please_merge_master#21675
adomani wants to merge 1 commit intomasterfrom
adomani/please_merge_mastr

Conversation

@adomani
Copy link
Copy Markdown
Contributor

@adomani adomani commented Feb 10, 2025

Mentioned on Zulip and should yield a more actionable message.


Open in Gitpod

@adomani
Copy link
Copy Markdown
Contributor Author

adomani commented Feb 10, 2025

bors d+

testing the new action: I am going to bors d- as soon as the label is added.

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Feb 10, 2025

✌️ adomani can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@ghost ghost added the delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). label Feb 10, 2025
@adomani
Copy link
Copy Markdown
Contributor Author

adomani commented Feb 10, 2025

bors d-

@github-actions
Copy link
Copy Markdown

PR summary 36c1ff17a7

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot added the CI Modifies the continuous integration setup or other automation label Feb 10, 2025
Copy link
Copy Markdown
Contributor

@grunweg grunweg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
maintainer delegate
(just in case this should wait on the bors d- fix, or so)

@github-actions
Copy link
Copy Markdown

🚀 Pull request has been placed on the maintainer queue by grunweg.

@github-actions github-actions bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Feb 10, 2025
@adomani adomani removed the delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). label Feb 10, 2025
@adomani
Copy link
Copy Markdown
Contributor Author

adomani commented Feb 10, 2025

Michael, thanks!

There is no need to wait for the bors d- fix: the test in this PR is independent of this PR and simply highlighted a failure of the other action.

There are plenty of other PRs where I can later test the revised bors d- script, so the decision on this PR should not be influenced by the other one.

@kim-em
Copy link
Copy Markdown
Contributor

kim-em commented Feb 11, 2025

bors merge

@ghost ghost added ready-to-merge This PR has been sent to bors. and removed maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. labels Feb 11, 2025
mathlib-bors bot pushed a commit that referenced this pull request Feb 11, 2025
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Feb 11, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title fix: rename file to please_merge_master [Merged by Bors] - fix: rename file to please_merge_master Feb 11, 2025
@mathlib-bors mathlib-bors bot closed this Feb 11, 2025
@mathlib-bors mathlib-bors bot deleted the adomani/please_merge_mastr branch February 11, 2025 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI Modifies the continuous integration setup or other automation ready-to-merge This PR has been sent to bors.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants