[Merged by Bors] - feat: subscript and superscript delaborators#23018
[Merged by Bors] - feat: subscript and superscript delaborators#23018
Conversation
PR summary fb95ea212cImport changes for modified filesNo significant changes to the import graph Import changes for all files
|
joneugster
left a comment
There was a problem hiding this comment.
The delaborator look good to me, thanks!
I suggest
maintainer merge
|
🚀 Pull request has been placed on the maintainer queue by joneugster. |
Co-authored-by: Jon Eugster <eugster.jon@gmail.com>
Co-authored-by: Jon Eugster <eugster.jon@gmail.com>
|
Thanks! Sorry this took so long to get through review. For sake of not adding any more delay, I took the liberty of pushing some changes to preserve the intent of using If the changes are to your satisfaction, please go ahead and merge! I'm delegating to you @gio256. bors d+ |
|
✌️ gio256 can now approve this pull request. To approve and merge a pull request, simply reply with |
|
Thanks! bors merge |
We add the functions `delabSubscript` and `delabSuperscript` in the `Mathlib.Tactic` namespace. These delaborators are triggered only if the entirety of the provided expression can be subscripted (respectively, superscripted). The delaborators are not exhaustive, in that they will not successfully delaborate every expression that is valid in a subscript or superscript. We instead aim to make them overly conservative, so that any expression which is successfully delaborated must be subscriptable (or superscriptable). Co-authored-by: Kyle Miller <kmill31415@gmail.com>
|
Pull request successfully merged into master. Build succeeded: |
We add the functions `delabSubscript` and `delabSuperscript` in the `Mathlib.Tactic` namespace. These delaborators are triggered only if the entirety of the provided expression can be subscripted (respectively, superscripted). The delaborators are not exhaustive, in that they will not successfully delaborate every expression that is valid in a subscript or superscript. We instead aim to make them overly conservative, so that any expression which is successfully delaborated must be subscriptable (or superscriptable). Co-authored-by: Kyle Miller <kmill31415@gmail.com>
We add the functions `delabSubscript` and `delabSuperscript` in the `Mathlib.Tactic` namespace. These delaborators are triggered only if the entirety of the provided expression can be subscripted (respectively, superscripted). The delaborators are not exhaustive, in that they will not successfully delaborate every expression that is valid in a subscript or superscript. We instead aim to make them overly conservative, so that any expression which is successfully delaborated must be subscriptable (or superscriptable). Co-authored-by: Kyle Miller <kmill31415@gmail.com>
We add the functions
delabSubscriptanddelabSuperscriptin theMathlib.Tacticnamespace. These delaborators are triggered only if the entirety of the provided expression can be subscripted (respectively, superscripted).The delaborators are not exhaustive, in that they will not successfully delaborate every expression that is valid in a subscript or superscript. We instead aim to make them overly conservative, so that any expression which is successfully delaborated must be subscriptable (or superscriptable).
This PR is intended to serve as a predecessor to #20719.